feat: replace svcl with native Core Audio - #10
Closed
Ayerdi wants to merge 8 commits into
Closed
Conversation
Owner
Author
|
Review note before merge: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
svcl.exe) runtime/install dependency with an in-process Windows Core Audio COM backend.WindowsEndpoint+LogitechGHubdetection model and the current PowerShell project structure.IMMDeviceEnumerator/IMMDevice, includingActive,Disabled,NotPresent, andUnpluggedstates.IPolicyConfigcompatibility boundary.Unknown, preserving the rule that an unknown state never changes the output.svcl.exeduring upgrades.submenu, and explicitly allow plural PowerShell helper nouns where the helper returns a collection.Why this PR is stacked
This is intentionally based on #9 (
agent/repository-standard-v1.2.5) so the diff stays focused on the native audio backend instead of mixing in the repository-standardization work already under review. After #9 merges, this PR can be retargeted/rebased ontomain.Validation
Validated on a Windows GitHub Actions runner (
windows-latest):Add-Type) compilation: passThe repository's normal
validateworkflow is also green on the current PR head:Compatibility / risk
Endpoint enumeration, endpoint state, properties, and reading default endpoints use documented Windows Core Audio/MMDevice APIs. Windows does not expose a documented public API for changing the system default endpoint; this PR keeps that operation isolated behind
IPolicyConfig::SetDefaultEndpoint, treats HRESULT failures as errors, and verifies the resulting default endpoint for all three roles instead of trusting the setter.CI cannot validate real headset/dongle behavior. Before merge I recommend a manual ON → OFF → ON test on:
WindowsEndpoint(for example the previously tested Jabra), andLogitechGHubfallback,checking that both the headset and fallback outputs are actually selected as expected.