Skip to content

ArchiveProgress: no way to hide the percentage label in the "stopped" state #23

Description

@jansaldo

Summary

ArchiveProgress always renders a {progress}% label for any status other than completed/error (including stopped), with no prop to suppress it. When a run is stopped mid-progress, the consuming app has no way to hide a percentage that no longer represents anything meaningful — only "freeze" it at a fixed value.

Where

Lg (the percent-label sub-component of ArchiveProgress), roughly:

: (
  <span className={...}>
    {progress}%
  </span>
)

This branch fires for status !== "completed" && status !== "error", so "stopped" always gets a numeric label — there's no "stopped"-specific case that omits it.

Ask

Add a way to omit the percentage label for the "stopped" status (e.g. render nothing, or an em dash, when status === "stopped"), so consumers aren't forced to display a number that doesn't correspond to anything once a run is stopped.

Screenshot

The attached screenshot shows the consuming app's workaround (freezing the value at 0% since there's no way to hide it) — note the 0% next to "Detener" even though nothing is running.

Image

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions