Skip to content

Refactor variable declarations to local scope#36

Open
Gogo1951 wants to merge 2 commits intoAznamirWoW:masterfrom
Gogo1951:patch-6
Open

Refactor variable declarations to local scope#36
Gogo1951 wants to merge 2 commits intoAznamirWoW:masterfrom
Gogo1951:patch-6

Conversation

@Gogo1951
Copy link
Contributor

@Gogo1951 Gogo1951 commented Mar 4, 2026

Fix for #35

@Gogo1951
Copy link
Contributor Author

Gogo1951 commented Mar 4, 2026

Likely needs a bit more testing. I think the saved variables need to be reset / needs to account for migration from old settings to new settings... but anyway, if you want to see some of the taint issues yourselves... I was getting a ton with ArkInventory, and Pawn, and Outfitter... they all use Ace libs. Just install them and do a load, you'll see the taint log.

Ping me if I can help at all.

Cheers!

Copy link
Contributor Author

@Gogo1951 Gogo1951 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few more variables switched over and I think that solved the last of my taint issues from Pally Power.

Execution tainted by PallyPower while reading ArkInventory - Interface/AddOns/ArkInventory/Core/ArkInventory.lua:3061

Execution tainted by PallyPower while reading ArkInventory - Interface/AddOns/ArkInventory/Locale/game.lua:415

Execution tainted by PallyPower while reading AttuneLang - Interface/AddOns/Attune/AttuneData.lua:1000

Execution tainted by PallyPower while reading LibStub - Interface/AddOns/AtlasLootClassic/Addons/Favourites_GUI.lua:13

Execution tainted by PallyPower while reading NIT - Interface/AddOns/NovaInstanceTracker/Modules/Data.lua:3002

Execution tainted by PallyPower while reading NIT - Interface/AddOns/NovaInstanceTracker/Modules/Options.lua:918 buildDatabase()

Execution tainted by PallyPower while reading NIT - Interface/AddOns/NovaInstanceTracker/Modules/Options.lua:956 buildDatabase()

Execution tainted by PallyPower while reading NIT - Interface/AddOns/NovaInstanceTracker/Modules/Zones.lua:182

@Gogo1951
Copy link
Contributor Author

Gogo1951 commented Mar 4, 2026

Just hacking on this while running dungeons. Needs review and testing. =P

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant