fix: change priority on upgrade tests

[sclarkso]

What

1. test/e2e/control_plane_automated_z_stream_upgrade.go — Added labels.MIDemandMedium to all 5 z-stream upgrade test entries (4.19-4.23)
2. test/e2e/nodepool_version_upgrade.go — Added labels.MIDemandMedium to all 3 nodepool version upgrade test entries
3. test/util/labels/labels.go — Updated comment to reflect that MIDemand labels are used for scheduling priority generally, not just container demand
4. test/cmd/aro-hcp-tests/main.go — Updated sort comment to match

Why

With this change, all 8 upgrade tests will be sorted to priority 1 (alongside cluster_nsg_subnet_reuse) and dispatched before the ~65 default-priority tests. They'll get MSI containers immediately at suite start instead of waiting 30-65 minutes. Since they take ~25 min total (create + upgrade + cleanup), they'll finish well before the 90-minute suite timeout even without the 150-minute bump.

Testing

e2e

Special notes for your reviewer

PR Checklist

• PR is scoped to a single task (no mixed concerns)
• Title follows Conventional Commits format
• Summary explains the "Why" behind the change
• Linked to relevant ticket/issue
• Screenshots included (if graph/UI/metrics changes)
• Self-reviewed the diff
• CI/CD checks are passing (ignore Tide)
• Draft PR used for WIP (if applicable)
• Commit history is clean (rebased/squashed)
• Tricky code blocks are commented
• Specific reviewers tagged
• All comment threads resolved before merge

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: sclarkso
Once this PR has been reviewed and has the lgtm label, please assign mgahagan73 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• test/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

[sclarkso]

/test e2e-parallel

[sclarkso]

/test e2e-parallel

[sclarkso]

/test e2e-parallel

[sclarkso]

/test e2e-parallel

[sclarkso]

/test e2e-parallel