Bump cs to 84b200b#5382
Merged
openshift-merge-bot[bot] merged 3 commits intoMay 28, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Updates E2E multiversion cluster install behavior to use explicit channel groups (including nightly for specific versions) and bumps the clusters-service image digest across dev environments.
Changes:
- Move channel-group selection into the multiversion table test and route specific versions to
nightly. - Persist chosen channel groups into
clusterParams.ChannelGroupandnodePoolParams.ChannelGroup. - Update rendered dev config YAMLs (and default config) to a new
aro-hcp-clusters-serviceimage digest.
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| test/e2e/complete_cluster_create_multiversion.go | Selects per-version channel groups and passes them into cluster/nodepool params for install/version resolution. |
| config/rendered/dev/prow/westus3.yaml | Bumps clusters-service image digest in dev prow environment. |
| config/rendered/dev/pers/westus3.yaml | Bumps clusters-service image digest in dev pers environment. |
| config/rendered/dev/perf/westus3.yaml | Bumps clusters-service image digest in dev perf environment. |
| config/rendered/dev/dev/westus3.yaml | Bumps clusters-service image digest in dev dev environment. |
| config/rendered/dev/cspr/westus3.yaml | Bumps clusters-service image digest in dev cspr environment. |
| config/rendered/dev/ci01/westus3.yaml | Bumps clusters-service image digest in dev ci01 environment. |
| config/config.yaml | Updates the default clusters-service image digest (and comment metadata). |
Comment on lines
+53
to
+58
| if version == "4.23" || version == "5.0" { | ||
| // Nightly channel picks up the Hypershift fix for Swift NIC scheduling overrides | ||
| // (https://github.com/openshift/hypershift/pull/8552) and test it against the CS bump. | ||
| channelGroup = "nightly" | ||
| nodePoolChannelGroup = "nightly" | ||
| } |
| registry: quay.io | ||
| repository: app-sre/aro-hcp-clusters-service | ||
| digest: sha256:c7c3d1b499fbc29760eda173fa1a8c4eb2cd2b0aa3a872c7fe3aacfc2ff8abe5 # dbb022a3dd3f0533ae1c8eebd4e6929ba1ca1ede (2026-05-19 06:44) | ||
| digest: sha256:449827838d1e8d19a442ca470c86acfc206628345b1a4dea47c57cbd4865b7c9 # 84b200b1d25eddb2d09ea820adcf5208e1de9779 |
Collaborator
Author
|
/test e2e-parallel |
Collaborator
Author
|
triggering the test again |
machi1990
force-pushed
the
bump/cs-to-84b200b
branch
from
f0c6120 to
010acc9
Compare
…ha 84b200b1d25eddb2d09ea820adcf5208e1de9779 To bring in the changes that's related to https://redhat.atlassian.net/browse/ARO-27209 See Azure#5346 for an attempt to add e2e that will gate against the hypershift change
…r NIC scheduling Pick the fix done in this PR openshift/hypershift#8552 and test it against the CS bump to validate that it works end to end
machi1990
force-pushed
the
bump/cs-to-84b200b
branch
from
032f15c to
adfd158
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: machi1990, raelga The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Bump cs to 84b200b and stop pinning it
Why
Bump CS and for a while use nightly for 5.0 which contains a fix for the NIC issue.
Work on backporting are underway and once Hypershift overrides are available, CS change will happen and we'll revert back to use the configured channel
Testing
Special notes for your reviewer
PR Checklist