restrict the image registry policy checks to dev#5391
Open
deads2k wants to merge 1 commit into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR narrows execution of the “Image Registry Policy … allowed registries … valid allowlist” E2E check so it only runs in development contexts, avoiding execution in stage/prod/integration suites.
Changes:
- Marked the “allowed registries / valid allowlist” Image Registry Policy E2E test as
DevelopmentOnly. - Updated suite-listing fixtures so that test is removed from stage/prod/integration suite outputs and appears only in the development rp-api-compat suite output.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
test/e2e/image_registry_policy.go |
Adds labels.DevelopmentOnly to the “allowed registries / valid allowlist” test case. |
test/testdata/zz_fixture_TestMainListSuitesForEachSuite_stage_parallelstage_parallel.txt |
Removes the allowlist test from the stage suite fixture output. |
test/testdata/zz_fixture_TestMainListSuitesForEachSuite_prod_parallelprod_parallel.txt |
Removes the allowlist test from the prod suite fixture output. |
test/testdata/zz_fixture_TestMainListSuitesForEachSuite_integration_parallelintegration_parallel.txt |
Removes the allowlist test from the integration suite fixture output. |
test/testdata/zz_fixture_TestMainListSuitesForEachSuite_rp_api_compat_all_parallel_01rp_api_compat_all_parallel_development.txt |
Adds the allowlist test to the development rp-api-compat suite fixture output. |
Comment on lines
123
to
127
| labels.High, | ||
| labels.Positive, | ||
| labels.CoreInfraService, | ||
| labels.DevelopmentOnly, | ||
| func(ctx context.Context) { |
12 tasks
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: deads2k, mvacula02 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Collaborator
|
/hold Let's test #5385 first. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Why
Testing
Special notes for your reviewer
PR Checklist