feat(fleet): add pipeline-based management cluster registration by geoberle · Pull Request #5436 · Azure/ARO-HCP

geoberle · 2026-05-29T10:01:17Z

Adds the fleet register CLI command and its pipeline integration, and removes the ManagementClusterMigrationController

The register command writes Stamp and ManagementCluster documents directly to CosmosDB during management cluster provisioning — the same data the migration controller previously synced from ClustersService, but driven from the pipeline instead.

What this PR does:

fleet register subcommand that creates/updates Stamp and ManagementCluster documents in CosmosDB
Registration pipeline (fleet/registration/) that runs the command as a Kubernetes Job during management cluster provisioning
Deterministic provision shard ID generation via UUID v5 same namespace UUID and AKS cluster name as the existing cluster-service Makefile, so both paths always produce the same ID
Removes the ManagementClusterMigrationController from the backend -— the register command now owns Stamp and ManagementCluster document creation
AdminAPI endpoint for fleet data access + E2E test validating registration succeeded

What this PR does NOT touch:

ClustersService provision shard registration (still helm-based)
Maestro consumer registration (still via maestro agent job)
These will move to fleet controllers in follow-up PRs

https://redhat.atlassian.net/browse/ARO-26925

Testing

The Fleet should have registered stamps with ready management clusters E2E test verifies that registration succeeded and an approved stamp and ready mgmt cluster are available in cosmos DB.

Special notes for your reviewer

PR Checklist

Copilot

Pull request overview

Adds pipeline-driven fleet registration so management cluster provisioning creates/updates Fleet Stamp and ManagementCluster records in CosmosDB, replacing the backend migration controller path.

Changes:

Adds fleet register CLI command and Helm Job/pipeline integration.
Adds config/schema support for stamp auto-approval.
Removes the backend ManagementClusterMigration controller and tests.

Reviewed changes

Copilot reviewed 20 out of 20 changed files in this pull request and generated 4 comments.

Show a summary per file

File	Description
`topology.yaml`	Adds Fleet Registration as a management child service group.
`fleet/registration/Chart.yaml`	Defines the new registration Helm chart.
`fleet/registration/values.yaml`	Provides Helm values for the registration Job.
`fleet/registration/templates/registration.job.yaml`	Renders the Kubernetes Job that runs `fleet register`.
`fleet/registration/pipeline.yaml`	Adds the rollout pipeline for registration.
`fleet/registration/zz_fixture_TestHelmTemplate_dev_westus3_svc_1_fleet_reg_dev_westus3_mgmt_1.yaml`	Adds rendered Helm fixture output.
`fleet/main.go`	Wires the new `register` subcommand.
`fleet/cmd/register/options.go`	Adds CLI options, validation, and DB client completion.
`fleet/cmd/register/cmd.go`	Implements Stamp and ManagementCluster registration writes.
`config/config.yaml`	Adds default fleet registration config.
`config/config.schema.json`	Adds schema for fleet registration config.
`config/rendered/dev/ci01/centralus.yaml`	Updates rendered dev config.
`config/rendered/dev/cspr/westus3.yaml`	Updates rendered dev config.
`config/rendered/dev/dev/westus3.yaml`	Updates rendered dev config.
`config/rendered/dev/perf/westus3.yaml`	Updates rendered dev config.
`config/rendered/dev/pers/westus3.yaml`	Updates rendered dev config.
`config/rendered/dev/prow/centralus.yaml`	Updates rendered dev config.
`backend/pkg/app/backend.go`	Stops constructing/running the migration controller.
`backend/pkg/controllers/managementclustercontrollers/management_cluster_migration.go`	Removes migration controller implementation.
`backend/pkg/controllers/managementclustercontrollers/management_cluster_migration_test.go`	Removes migration controller tests.

Copilot

Pull request overview

Copilot reviewed 23 out of 23 changed files in this pull request and generated 3 comments.

Adds the fleet register CLI command and its pipeline integration, and removes the ManagementClusterMigrationController https://redhat.atlassian.net/browse/ARO-26925 The register command writes Stamp and ManagementCluster documents directly to CosmosDB during management cluster provisioning — the same data the migration controller previously synced from ClustersService, but driven from the pipeline instead. What this PR does: - fleet register subcommand that creates/updates Stamp and ManagementCluster documents in CosmosDB - Registration pipeline (fleet/registration/) that runs the command as a Kubernetes Job during management cluster provisioning - Deterministic provision shard ID generation via UUID v5 same namespace UUID and AKS cluster name as the existing cluster-service Makefile, so both paths always produce the same ID - Removes the ManagementClusterMigrationController from the backend — the register command now owns Stamp and ManagementCluster document creation What this PR does NOT touch: - ClustersService provision shard registration (still helm-based) - Maestro consumer registration (still via maestro agent job) - These will move to fleet controllers in follow-up PRs What this PR does NOT touch: - ClustersService provision shard registration (still helm-based) - Maestro consumer registration (still via maestro agent job) - These will move to fleet controllers in follow-up PRs

Copilot

Pull request overview

Copilot reviewed 26 out of 26 changed files in this pull request and generated 1 comment.

Copilot

Pull request overview

Copilot reviewed 37 out of 38 changed files in this pull request and generated 2 comments.

Copilot

Pull request overview

Copilot reviewed 37 out of 37 changed files in this pull request and generated 1 comment.

geoberle · 2026-05-29T18:30:33Z

/test e2e-parallel

Signed-off-by: Gerd Oberlechner <goberlec@redhat.com>

Copilot

Pull request overview

Copilot reviewed 38 out of 38 changed files in this pull request and generated 1 comment.

geoberle · 2026-05-30T09:44:25Z

/test verify

Copilot

Pull request overview

Copilot reviewed 43 out of 43 changed files in this pull request and generated no new comments.

bennerv

/lgtm

openshift-ci · 2026-05-30T17:30:20Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bennerv, geoberle

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [bennerv,geoberle]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-merge-bot · 2026-05-30T20:57:59Z

/retest-required

Remaining retests: 0 against base HEAD cfa46fa and 2 for PR HEAD ca0879b in total

Copilot AI review requested due to automatic review settings May 29, 2026 10:01

openshift-ci Bot added the approved label May 29, 2026

openshift-ci Bot requested review from bennerv and mbarnes May 29, 2026 10:01

openshift-ci Bot added the needs-rebase label May 29, 2026

Copilot started reviewing on behalf of geoberle May 29, 2026 10:01 View session

Copilot AI reviewed May 29, 2026

View reviewed changes

Comment thread fleet/registration/values.yaml Outdated

Comment thread fleet/cmd/register/cmd.go Outdated

Comment thread fleet/cmd/register/cmd.go Outdated

Comment thread fleet/cmd/register/cmd.go

geoberle force-pushed the fleet-registration branch 2 times, most recently from ecf1f70 to fc2cf07 Compare May 29, 2026 10:38

Copilot AI review requested due to automatic review settings May 29, 2026 10:38

openshift-ci Bot removed the needs-rebase label May 29, 2026

Copilot started reviewing on behalf of geoberle May 29, 2026 10:38 View session

Copilot AI reviewed May 29, 2026

View reviewed changes

Comment thread fleet/registration/values.yaml Outdated

Comment thread fleet/registration/values.yaml Outdated

Comment thread fleet/cmd/register/options.go

geoberle force-pushed the fleet-registration branch from fc2cf07 to f6568bb Compare May 29, 2026 10:50

Copilot AI review requested due to automatic review settings May 29, 2026 11:00

geoberle force-pushed the fleet-registration branch from f6568bb to a33747b Compare May 29, 2026 11:00

Copilot started reviewing on behalf of geoberle May 29, 2026 11:00 View session

Copilot AI reviewed May 29, 2026

View reviewed changes

Comment thread fleet/cmd/register/cmd_test.go

Copilot AI review requested due to automatic review settings May 29, 2026 13:48

geoberle force-pushed the fleet-registration branch from 819efc6 to afe99ab Compare May 29, 2026 13:48

Copilot started reviewing on behalf of geoberle May 29, 2026 13:49 View session

Copilot AI reviewed May 29, 2026

View reviewed changes

Comment thread fleet/cmd/register/cmd.go

Comment thread test/go.mod Outdated

geoberle force-pushed the fleet-registration branch 2 times, most recently from e62140f to b3d7246 Compare May 29, 2026 14:08

Copilot AI review requested due to automatic review settings May 29, 2026 14:08

Copilot started reviewing on behalf of geoberle May 29, 2026 14:08 View session

Copilot AI reviewed May 29, 2026

View reviewed changes

Comment thread fleet/cmd/register/cmd.go

stamp admin api endpoints + registration validation e2e

d321241

geoberle force-pushed the fleet-registration branch from b3d7246 to d321241 Compare May 29, 2026 14:28

rachelvweber reviewed May 29, 2026

View reviewed changes

Comment thread config/config.schema.json

stampIdentifier mandatory in config

7aff384

Signed-off-by: Gerd Oberlechner <goberlec@redhat.com>

Copilot AI review requested due to automatic review settings May 30, 2026 06:36

Copilot started reviewing on behalf of geoberle May 30, 2026 06:36 View session

Copilot AI reviewed May 30, 2026

View reviewed changes

Comment thread admin/server/handlers/stamp/stamp_get.go Outdated

unit tests for handlers

97c7cee

geoberle closed this May 30, 2026

geoberle reopened this May 30, 2026

bennerv reviewed May 30, 2026

View reviewed changes

Comment thread admin/server/handlers/stamp/managementcluster.go

bennerv reviewed May 30, 2026

View reviewed changes

Comment thread admin/server/handlers/stamp/managementcluster.go Outdated

bennerv reviewed May 30, 2026

View reviewed changes

Comment thread admin/server/handlers/stamp/stamp.go Outdated

bennerv reviewed May 30, 2026

View reviewed changes

Comment thread admin/server/handlers/stamp/stamp.go Outdated

bennerv reviewed May 30, 2026

View reviewed changes

Comment thread fleet/cmd/register/cmd.go Outdated

bennerv reviewed May 30, 2026

View reviewed changes

Comment thread fleet/cmd/register/options.go

bennerv reviewed May 30, 2026

View reviewed changes

Comment thread fleet/cmd/register/options.go

bennerv reviewed May 30, 2026

View reviewed changes

Comment thread fleet/cmd/register/options.go

geoberle added 2 commits May 30, 2026 19:06

wrap WriteJSONResponse errors with TrackError in admin handlers

1308db0

enrich logger with stampIdentifier upfront in register command

70042a2

Copilot AI review requested due to automatic review settings May 30, 2026 17:12

Copilot started reviewing on behalf of geoberle May 30, 2026 17:12 View session

Copilot AI reviewed May 30, 2026

View reviewed changes

add comment about deterministic provision shard ID generation

ca0879b

bennerv reviewed May 30, 2026

View reviewed changes

openshift-ci Bot assigned bennerv May 30, 2026

openshift-ci Bot added the lgtm label May 30, 2026

openshift-merge-bot Bot merged commit 99dcb99 into Azure:main May 30, 2026
15 checks passed

Conversation

geoberle commented May 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What this PR does:

What this PR does NOT touch:

Testing

Special notes for your reviewer

PR Checklist

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

geoberle commented May 29, 2026

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

geoberle commented May 30, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

bennerv left a comment

Choose a reason for hiding this comment

Uh oh!

openshift-ci Bot commented May 30, 2026

Uh oh!

openshift-merge-bot Bot commented May 30, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

geoberle commented May 29, 2026 •

edited

Loading