api: Add Conditions to ARM Resource Types#5445
Open
bennerv wants to merge 4 commits into
Open
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bennerv The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Copilot stopped reviewing on behalf of
bennerv due to an error
May 29, 2026 16:29
bennerv
force-pushed
the
bvesel/add-conditions-to-resource-types
branch
3 times, most recently
from
5efa3bf to
3331e29
Compare
bennerv
force-pushed
the
bvesel/add-conditions-to-resource-types
branch
from
3331e29 to
607bfff
Compare
The PKO cleanup step is meant to be best-effort while ARO-23308 removes Package Operator from existing management clusters. A production run still failed after cleanup made resources disappear: later dynamic list calls returned "the server could not find the requested resource", incremented the error count, and caused a non-zero exit. Treat missing PKO custom resources as already cleaned up in delete, count, and finalizer-removal paths. Also keep cleanup errors as warnings so the helper exits 0 after best-effort cleanup attempts; setup/client construction errors remain fatal. Validation: * go test ./dev-infrastructure/scripts/cleanup-pko-resources/... * go vet ./dev-infrastructure/scripts/cleanup-pko-resources/...
The ExternalAuth Condition field is read-only (server-managed) and should not be converted from client input. Remove the conversion from ConvertToInternal in v20240610preview and v20251223preview, and zero the field in fuzz tests since it no longer round-trips. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
bennerv
force-pushed
the
bvesel/add-conditions-to-resource-types
branch
2 times, most recently
from
bf38e89 to
99ed3e1
Compare
Copilot stopped reviewing on behalf of
bennerv due to an error
May 29, 2026 21:03
bennerv
force-pushed
the
bvesel/add-conditions-to-resource-types
branch
2 times, most recently
from
0f16a15 to
fef0d82
Compare
bennerv
force-pushed
the
bvesel/add-conditions-to-resource-types
branch
from
fef0d82 to
724697c
Compare
bennerv
force-pushed
the
bvesel/add-conditions-to-resource-types
branch
from
724697c to
6de6fae
Compare
Copilot stopped reviewing on behalf of
bennerv due to an error
May 29, 2026 22:21
bennerv
force-pushed
the
bvesel/add-conditions-to-resource-types
branch
from
6de6fae to
078b4cd
Compare
bennerv
force-pushed
the
bvesel/add-conditions-to-resource-types
branch
from
078b4cd to
1c21981
Compare
Adds read-only conditions (following Kubernetes status.conditions conventions) to HCPOpenShiftCluster, NodePool, and ExternalAuth resource types under a new API version 2026-06-30-preview. Conditions use a generic Condition model with ConditionType union (Available, Degraded, Progressing) shared across all resource types. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
bennerv
force-pushed
the
bvesel/add-conditions-to-resource-types
branch
from
1c21981 to
e078719
Compare
|
@bennerv: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Copilot stopped reviewing on behalf of
bennerv due to an error
May 30, 2026 18:52
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds a read-only conditions API field to our resource types to expose status information and the addition of a new api version 2026-05-31-preview.
Why
We can leverage this to expose read-only information similar to k8s conditions which tell the customer if the cluster is degraded. Because of the controller implementation of the backend, and the fact that customers can make changes to permissions, infra, etc. which can result in degradation of functionality on the cluster, this allows us to expose that information without requiring an ongoing customer operation to do so to move the resource type into a failed state.
Testing
The e2e test, integration test, and unit test additions should cover this use case.
Special notes for your reviewer
PR Checklist