grafanactl: reconcile ADX datasources

[swiencki]

What

Extends the existing GrafanaDatasources typed step and grafanactl modify datasource reconcile flow with optional ADX/Kusto datasource support.

This keeps Azure Monitor datasource reconciliation as the default path, adds ADX flags only when configured, and supports create/update/delete desired-state behavior for the named ADX datasource.

Why

ARO-HCP needs to provision ADX datasources through the existing typed/prebuilt-binary rollout pattern instead of introducing an ADX-only EV2 shell path or rollout-time go run.

Testing

• go test ./pipelines/types ./tools/grafanactl/...
• make lint

Cross-repo rollout

Merge order is required:

1. This PR lands first.
2. ARO-HCP consumes the merged ARO-Tools version in ARO-26057: add ADX Grafana datasource provisioning ARO-HCP#4878.
3. sdp-pipelines consumes the merged ARO-Tools + ARO-HCP versions in https://dev.azure.com/msazure/AzureRedHatOpenShift/_git/sdp-pipelines/pullrequest/15393796 and regenerates rollout artifacts.

[Copilot]

Pull request overview

Adds a new grafanactl modify datasource reconcile-adx subcommand to create/update a single Azure Data Explorer (ADX) Grafana datasource via the Grafana REST API (rather than relying on Azure CLI datasource commands), along with supporting Grafana client capabilities and tests.

Changes:

• Introduces ADX reconcile command + option parsing/validation/completion flow.
• Extends the internal Grafana client with datasource type listing and status-aware create/update requests.
• Updates docs and adds unit tests for the new ADX logic and client behavior.

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
tools/grafanactl/internal/grafana/client.go	Adds status-aware datasource create/update helpers and datasource type listing.
tools/grafanactl/internal/grafana/client_test.go	Adds tests for create/update request behavior and error reporting.
tools/grafanactl/cmd/modify/cmd.go	Registers the new modify datasource reconcile-adx subcommand.
tools/grafanactl/cmd/modify/adx_options.go	Implements flags, validation, and completion for ADX reconcile options.
tools/grafanactl/cmd/modify/adx.go	Implements reconcile logic (create vs update) and desired datasource payload generation.
tools/grafanactl/cmd/modify/adx_options_test.go	Adds unit tests covering validation and reconcile create/update paths.
tools/grafanactl/README.md	Documents ADX datasource reconcile usage and common flag alternative.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

Pull request overview

Copilot reviewed 12 out of 12 changed files in this pull request and generated 4 comments.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[SudoBrendan]

Adding state to our fake client unlocks testing of idempotency (retry) logic of POST. Does this work as expected today?

[Copilot]

Pull request overview

Copilot reviewed 12 out of 12 changed files in this pull request and generated 2 comments.

Comments suppressed due to low confidence (1)

tools/grafanactl/internal/grafana/client.go:221

• DeleteDataSource builds the request path via path.Join("api/datasources/name", url.PathEscape(dataSourceName)). url.PathEscape does not escape ./.., and path.Join will path-clean those segments (e.g., name ".." collapses to api/datasources), which can send the DELETE to the wrong endpoint. Prefer concatenating the fixed prefix with the escaped name (or building the URL without path.Join/path.Clean) so user-supplied names cannot alter path structure via dot-segments.

func (c *Client) DeleteDataSource(ctx context.Context, dataSourceName string) error {
	apiPath := path.Join("api/datasources/name", url.PathEscape(dataSourceName))
	if _, err := c.doGrafanaRequest(ctx, http.MethodDelete, apiPath, nil, http.StatusOK, http.StatusAccepted, http.StatusNotFound); err != nil {
		return fmt.Errorf("failed to delete datasource %q: %w", dataSourceName, err)