Skip to content

feat(alerter): allow configuring alerter to only watch alertrules in a specific namespace#1136

Draft
matucker-msft wants to merge 1 commit into
mainfrom
alerter-namespace-filter
Draft

feat(alerter): allow configuring alerter to only watch alertrules in a specific namespace#1136
matucker-msft wants to merge 1 commit into
mainfrom
alerter-namespace-filter

Conversation

@matucker-msft
Copy link
Copy Markdown
Member

No description provided.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds optional namespace scoping to the alerter’s AlertRule discovery, allowing deployments to limit rule loading to a single Kubernetes namespace (while preserving the current “all namespaces” behavior by default).

Changes:

  • Added --namespace CLI flag to configure which namespace the alerter loads AlertRules from.
  • Threaded the namespace option through AlerterOpts into the rules store.
  • Updated the rules store list call to apply client.InNamespace(...) when configured, and added unit tests covering both scoped and unscoped behavior.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

File Description
cmd/alerter/main.go Adds --namespace flag and passes it into the alerter service options.
alerter/service.go Extends AlerterOpts with Namespace and forwards it to the rules store.
alerter/rules/store.go Filters the controller-runtime client List call by namespace when configured.
alerter/rules/store_test.go Adds tests validating rule reload behavior for all namespaces vs a single namespace.

Comment on lines +18 to +21
TypeMeta: metav1.TypeMeta{
APIVersion: "adx-mon.azure.com/v1",
Kind: "AlertRule",
},
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants