feat(alerter): allow configuring alerter to only watch alertrules in a specific namespace#1136
Draft
matucker-msft wants to merge 1 commit into
Draft
feat(alerter): allow configuring alerter to only watch alertrules in a specific namespace#1136matucker-msft wants to merge 1 commit into
matucker-msft wants to merge 1 commit into
Conversation
…a specific namespace
Contributor
There was a problem hiding this comment.
Pull request overview
Adds optional namespace scoping to the alerter’s AlertRule discovery, allowing deployments to limit rule loading to a single Kubernetes namespace (while preserving the current “all namespaces” behavior by default).
Changes:
- Added
--namespaceCLI flag to configure which namespace the alerter loads AlertRules from. - Threaded the namespace option through
AlerterOptsinto the rules store. - Updated the rules store list call to apply
client.InNamespace(...)when configured, and added unit tests covering both scoped and unscoped behavior.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| cmd/alerter/main.go | Adds --namespace flag and passes it into the alerter service options. |
| alerter/service.go | Extends AlerterOpts with Namespace and forwards it to the rules store. |
| alerter/rules/store.go | Filters the controller-runtime client List call by namespace when configured. |
| alerter/rules/store_test.go | Adds tests validating rule reload behavior for all namespaces vs a single namespace. |
Comment on lines
+18
to
+21
| TypeMeta: metav1.TypeMeta{ | ||
| APIVersion: "adx-mon.azure.com/v1", | ||
| Kind: "AlertRule", | ||
| }, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.