feat(alerter): fail alertrule linting if rule exposes multiple ambiguous reserved words#1159
Merged
Merged
Conversation
…ous reserved words
Contributor
There was a problem hiding this comment.
Pull request overview
This PR strengthens AlertRule linting/execution by detecting and rejecting ambiguous duplicate reserved alert output columns that differ only by casing (e.g., Severity vs severity), so adx-mon fails clearly instead of implicitly picking one value.
Changes:
- Added reserved-column duplicate detection (case-insensitive) before row-to-alert conversion in the alerter executor.
- Refactored
Lintto be testable via an injectable Kusto client factory and to return a more informative lint error (lint.Err()). - Added unit tests covering duplicate reserved columns (failure) and duplicate custom columns (allowed).
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
alerter/service.go |
Refactors linting to use an injectable Kusto client factory and returns lint.Err() on failures. |
alerter/lint_test.go |
Adds a lint-level test ensuring duplicate reserved columns (different casing) fail lint with a clear message. |
alerter/fake.go |
Enhances lint handler to accumulate failure messages and expose them via Err(). |
alerter/engine/executor.go |
Adds reserved notification column validation to reject duplicate reserved columns with different casing. |
alerter/engine/executor_test.go |
Adds executor tests for duplicate reserved columns (fail) and duplicate custom columns (allowed). |
jessejlt
approved these changes
May 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Severityandseverity.