fix: Foundry E2E quick-wins (#111, #115, #116, #117)#118
Merged
Conversation
Bundles together the four lowest-risk findings from the Foundry agent end-to-end validation in #78. No backend changes; all fixes are docs, templates, or CLI surface. * #115 - implement `agentops config validate -c <path>`. Loads the given run.yaml through the same Pydantic models the runner uses; prints a one-line success summary or a clear validation error and exits non-zero on failure. Replaces the previous '(planned)' stub. * #116 - raise default `avg_latency_seconds` thresholds in the four baseline bundles to reflect Foundry cloud-evaluation reality (~15-25s/row including the judge-evaluator pipeline). 10s -> 30s for conversational/model/rag/safe; 15s -> 45s for agent_workflow. Tutorial tables updated to match. * #117 - document in docs/bundles.md that the agent_workflow_baseline is only meaningful against agents that actually expose tool definitions, and that avg_latency_seconds measures the full pipeline rather than the agent alone. * #111 - document in docs/tutorial-basic-foundry-agent.md and docs/how-it-works.md that omitting the `:version` suffix on a named Foundry agent resolves to 'latest' at run time, and that CI / baseline runs should pin a version for reproducibility. Tests: 285 passed (3 new for config validate). Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This was referenced Apr 29, 2026
Dongbumlee
added a commit
that referenced
this pull request
Apr 29, 2026
Revert "fix: Foundry E2E quick-wins (#118)"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bundles the four lowest-risk findings from the Foundry agent end-to-end validation in #78 into a single, low-risk PR. No backend changes; all fixes are docs, templates, or CLI surface.
Fixes
agentops config validate -c <path>. Loads the given run.yaml through the same Pydantic models the runner uses, prints a one-line success summary or a clear error, and exits non-zero on failure.avg_latency_secondsthresholds across baseline bundles to match Foundry cloud-evaluation reality (15–25 s/row observed):conversational_agent_baseline,model_quality_baseline,rag_quality_baseline,safe_agent_baselineagent_workflow_baselinedocs/bundles.mdthatagent_workflow_baselineis only meaningful against agents that expose tool definitions, and thatavg_latency_secondsmeasures the full pipeline rather than the agent alone.docs/how-it-works.mdthat omitting the:versionsuffix on a named Foundry agent resolves to latest at run time, and that CI / baseline runs should pin a version.Out of scope (separate follow-up issues)
Validation
3 new unit tests for
config validate(success, missing file, invalid schema).Manual smoke: