Skip to content

chore(ci): retire one-shot tombstone publish jobs#198

Merged
Dongbumlee merged 2 commits into
developfrom
chore/retire-tombstone-pipeline-jobs
May 29, 2026
Merged

chore(ci): retire one-shot tombstone publish jobs#198
Dongbumlee merged 2 commits into
developfrom
chore/retire-tombstone-pipeline-jobs

Conversation

@Dongbumlee
Copy link
Copy Markdown
Collaborator

Summary

The agentops-toolkitagentops-accelerator deprecation tombstones were one-shot publishes for v0.3.0 / v0.3.1 (PyPI manually uploaded, VSIX shipped via Marketplace). Per the user directive "once we put the tombstone (v0.3.0), we don't need to care of it anymore after new releasing" and "make sure our release pipeline will not touch any tombstone works anymore", this PR removes every tombstone job, prose mention, and orphaned source file from the repo.

Refs: #181

Workflow deletions

release.yml (548 → 281 LOC)

  • build-pypi-tombstone
  • publish-tombstone-testpypi
  • verify-tombstone-testpypi
  • publish-tombstone-pypi
  • publish-tombstone-vsix

staging.yml (474 → 208 LOC)

  • build-pypi-tombstone
  • publish-tombstone-testpypi
  • verify-tombstone-testpypi
  • publish-tombstone-vsix-prerelease

cut-release.yml (211 → 173 LOC)

  • ❌ Sub-blocks updating tombstones/vscode/package.json, tombstones/pypi/pyproject.toml, tombstones/vscode/CHANGELOG.md
  • ❌ Tombstone paths removed from git add in commit step
  • ❌ Tombstone bullets removed from PR body markdown

github-release simplification

- needs: [publish-pypi, publish-vsix, publish-tombstone-pypi, publish-tombstone-vsix]
- if: always() && needs.publish-pypi.result == 'success' && needs.publish-vsix.result == 'success'
+ needs: [publish-pypi, publish-vsix]
+ if: needs.publish-pypi.result == 'success' && needs.publish-vsix.result == 'success'

The always() guard was dead code: with both deps now required, GitHub Actions implicitly skips the job whenever either need is non-success, and the explicit == 'success' checks would have caught it anyway. Verified behavior-equivalent across all four outcome combinations (both-success, partial, cancelled, upstream-failure).

Repo hygiene (per Critic findings)

  • 🗑️ scripts/verify_tombstones.py — already-done one-shot harness; expected 6 release assets but the new pipeline ships 3, so it would fail with misleading errors.
  • 🗑️ docs/verifying-tombstones.md — referenced deleted CI jobs by name + line numbers.
  • 🗑️ tombstones/pypi/ (entire dir)
  • 🗑️ tombstones/vscode/{LICENSE,CHANGELOG.md,icon.png,package.json,README.md,tsconfig.json,.vscodeignore,src/} — orphaned source no workflow consumes.
  • tombstones/vscode/CDN_DEPRECATION_REQUEST.md kept — template for the still-pending Microsoft CDN deprecation request.

Line-ending consistency

  • .gitattributes pinning *.yml, *.yaml, *.sh, *.md, *.py to LF so Windows clones with core.autocrlf=true don't repeatedly flip workflow files.
  • 🔄 Normalized _build.yml and ci.yml (previously CRLF) to LF — all 7 files in .github/workflows/ now share one convention.

Verification

  • ✅ YAML parses for all 5 workflow files
  • ✅ Zero tombstone refs in .github/, scripts/, docs/, or top-level docs (only in CHANGELOG historical entries and CDN_DEPRECATION_REQUEST.md)
  • ✅ All artifact wiring (dist + vsix) preserved; no dangling download-artifact references
  • ✅ Next-release walk-through (v0.3.1 tag → build → publish-testpypi → verify-testpypi → publish-pypi → publish-vsix → github-release) DAG is intact

Next steps (out of scope for this PR)

  • File Microsoft CDN deprecation request per tombstones/vscode/CDN_DEPRECATION_REQUEST.md to retire the legacy Marketplace listing

🤖 Generated with GitHub Copilot CLI

Co-authored-by: Copilot 223556219+Copilot@users.noreply.github.com

DB Lee and others added 2 commits May 28, 2026 21:34
The agentops-toolkit -> agentops-accelerator deprecation tombstones
were shipped one-shot for v0.3.0 / v0.3.1 (PyPI manual upload, VSIX
via marketplace). Going forward, the release pipeline must not touch
any tombstone work.

Workflow deletions:
- release.yml: build-pypi-tombstone, publish-tombstone-testpypi,
  verify-tombstone-testpypi, publish-tombstone-pypi,
  publish-tombstone-vsix
- staging.yml: build-pypi-tombstone, publish-tombstone-testpypi,
  verify-tombstone-testpypi, publish-tombstone-vsix-prerelease
- cut-release.yml: 3 tombstone version-sync sub-blocks + git-add
  paths + PR-body bullets

github-release simplification:
- needs: [publish-pypi, publish-vsix] (was: + 2 tombstone jobs)
- if: drop dead 'always() &&' guard (both deps are required, so
  always() never changes behavior). Verified equivalent on all four
  outcome combinations: both-success, partial-success, cancelled,
  upstream-failure.

Repo hygiene:
- Delete scripts/verify_tombstones.py (already-done one-shot harness;
  would now fail with 'asset not found' on its 6-asset expectation
  because the pipeline ships only 3 assets).
- Delete docs/verifying-tombstones.md (references deleted CI jobs).
- Delete tombstones/pypi/ and tombstones/vscode/{LICENSE,CHANGELOG.md,
  icon.png,package.json,README.md,tsconfig.json,.vscodeignore,src} —
  orphaned source no workflow consumes anymore.
- Keep tombstones/vscode/CDN_DEPRECATION_REQUEST.md as the template
  for the still-pending Microsoft CDN deprecation request.

Line-ending consistency:
- Add .gitattributes pinning *.yml / *.yaml / *.sh / *.md / *.py to
  LF so Windows clones with core.autocrlf=true don't repeatedly flip
  workflow files between CRLF and LF.
- Normalize _build.yml and ci.yml (previously CRLF) to LF so the
  entire .github/workflows/ tree uses one convention.

Tombstone references remaining (intentional): CHANGELOG.md historical
v0.3.0 entries; tombstones/vscode/CDN_DEPRECATION_REQUEST.md.

Refs: #181

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…tone-pipeline-jobs

# Conflicts:
#	CHANGELOG.md
@Dongbumlee Dongbumlee merged commit afaa758 into develop May 29, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant