chore(ci): retire one-shot tombstone publish jobs#198
Merged
Conversation
The agentops-toolkit -> agentops-accelerator deprecation tombstones
were shipped one-shot for v0.3.0 / v0.3.1 (PyPI manual upload, VSIX
via marketplace). Going forward, the release pipeline must not touch
any tombstone work.
Workflow deletions:
- release.yml: build-pypi-tombstone, publish-tombstone-testpypi,
verify-tombstone-testpypi, publish-tombstone-pypi,
publish-tombstone-vsix
- staging.yml: build-pypi-tombstone, publish-tombstone-testpypi,
verify-tombstone-testpypi, publish-tombstone-vsix-prerelease
- cut-release.yml: 3 tombstone version-sync sub-blocks + git-add
paths + PR-body bullets
github-release simplification:
- needs: [publish-pypi, publish-vsix] (was: + 2 tombstone jobs)
- if: drop dead 'always() &&' guard (both deps are required, so
always() never changes behavior). Verified equivalent on all four
outcome combinations: both-success, partial-success, cancelled,
upstream-failure.
Repo hygiene:
- Delete scripts/verify_tombstones.py (already-done one-shot harness;
would now fail with 'asset not found' on its 6-asset expectation
because the pipeline ships only 3 assets).
- Delete docs/verifying-tombstones.md (references deleted CI jobs).
- Delete tombstones/pypi/ and tombstones/vscode/{LICENSE,CHANGELOG.md,
icon.png,package.json,README.md,tsconfig.json,.vscodeignore,src} —
orphaned source no workflow consumes anymore.
- Keep tombstones/vscode/CDN_DEPRECATION_REQUEST.md as the template
for the still-pending Microsoft CDN deprecation request.
Line-ending consistency:
- Add .gitattributes pinning *.yml / *.yaml / *.sh / *.md / *.py to
LF so Windows clones with core.autocrlf=true don't repeatedly flip
workflow files between CRLF and LF.
- Normalize _build.yml and ci.yml (previously CRLF) to LF so the
entire .github/workflows/ tree uses one convention.
Tombstone references remaining (intentional): CHANGELOG.md historical
v0.3.0 entries; tombstones/vscode/CDN_DEPRECATION_REQUEST.md.
Refs: #181
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…tone-pipeline-jobs # Conflicts: # CHANGELOG.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
agentops-toolkit→agentops-acceleratordeprecation tombstones were one-shot publishes for v0.3.0 / v0.3.1 (PyPI manually uploaded, VSIX shipped via Marketplace). Per the user directive "once we put the tombstone (v0.3.0), we don't need to care of it anymore after new releasing" and "make sure our release pipeline will not touch any tombstone works anymore", this PR removes every tombstone job, prose mention, and orphaned source file from the repo.Refs: #181
Workflow deletions
release.yml(548 → 281 LOC)build-pypi-tombstonepublish-tombstone-testpypiverify-tombstone-testpypipublish-tombstone-pypipublish-tombstone-vsixstaging.yml(474 → 208 LOC)build-pypi-tombstonepublish-tombstone-testpypiverify-tombstone-testpypipublish-tombstone-vsix-prereleasecut-release.yml(211 → 173 LOC)tombstones/vscode/package.json,tombstones/pypi/pyproject.toml,tombstones/vscode/CHANGELOG.mdgit addin commit stepgithub-releasesimplificationThe
always()guard was dead code: with both deps now required, GitHub Actions implicitly skips the job whenever either need is non-success, and the explicit== 'success'checks would have caught it anyway. Verified behavior-equivalent across all four outcome combinations (both-success, partial, cancelled, upstream-failure).Repo hygiene (per Critic findings)
scripts/verify_tombstones.py— already-done one-shot harness; expected 6 release assets but the new pipeline ships 3, so it would fail with misleading errors.docs/verifying-tombstones.md— referenced deleted CI jobs by name + line numbers.tombstones/pypi/(entire dir)tombstones/vscode/{LICENSE,CHANGELOG.md,icon.png,package.json,README.md,tsconfig.json,.vscodeignore,src/}— orphaned source no workflow consumes.tombstones/vscode/CDN_DEPRECATION_REQUEST.mdkept — template for the still-pending Microsoft CDN deprecation request.Line-ending consistency
.gitattributespinning*.yml,*.yaml,*.sh,*.md,*.pyto LF so Windows clones withcore.autocrlf=truedon't repeatedly flip workflow files._build.ymlandci.yml(previously CRLF) to LF — all 7 files in.github/workflows/now share one convention.Verification
.github/,scripts/,docs/, or top-level docs (only in CHANGELOG historical entries andCDN_DEPRECATION_REQUEST.md)dist+vsix) preserved; no danglingdownload-artifactreferencesNext steps (out of scope for this PR)
tombstones/vscode/CDN_DEPRECATION_REQUEST.mdto retire the legacy Marketplace listing🤖 Generated with GitHub Copilot CLI
Co-authored-by: Copilot 223556219+Copilot@users.noreply.github.com