Skip to content

frontend: Reenable i18n LanguageDetector#701

Merged
sniok merged 1 commit into
Azure:headlamp-downstreamfrom
sniok:hl-fix-i18n-detection
Jun 1, 2026
Merged

frontend: Reenable i18n LanguageDetector#701
sniok merged 1 commit into
Azure:headlamp-downstreamfrom
sniok:hl-fix-i18n-detection

Conversation

@sniok
Copy link
Copy Markdown
Collaborator

@sniok sniok commented Jun 1, 2026

this PR reverts changes that removed LanguageDetector code

How to test:

  1. Go to the settings and change the language
  2. restart the app and check if the language choice persisted

Copilot AI review requested due to automatic review settings June 1, 2026 14:25
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR re-enables i18next’s i18next-browser-languagedetector in the frontend i18n setup so the app can detect and persist the user’s selected language across restarts.

Changes:

  • Re-introduces i18next-browser-languagedetector usage in the i18n initialization flow.
  • Removes the hard-coded lng: 'en' override so i18n can select a language dynamically.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread frontend/src/i18n/config.ts
@sniok sniok requested a review from skoeva June 1, 2026 14:41
@sniok sniok merged commit 477a4c5 into Azure:headlamp-downstream Jun 1, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants