Skip to content

Fix typespec-go nightly build failure#1952

Merged
jhendrixMSFT merged 9 commits into
mainfrom
copilot/fix-nightly-build-pipeline
May 12, 2026
Merged

Fix typespec-go nightly build failure#1952
jhendrixMSFT merged 9 commits into
mainfrom
copilot/fix-nightly-build-pipeline

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented May 6, 2026

Upgrades @typespec/spec-api to 0.1.0-dev.3 to fix the nightly build pipeline for the typespec-go package.
Previously, this issue is solved by this PR, but it's overwritten by this PR

Agent-Logs-Url: https://github.com/Azure/autorest.go/sessions/ce314106-5558-426a-a36e-174ec3063bdc

Co-authored-by: JiaqiZhang-Dev <194873822+JiaqiZhang-Dev@users.noreply.github.com>
@JiaqiZhang-Dev
Copy link
Copy Markdown
Member

@copilot please revert the code change and just skip this test: test/azure-http-specs/resiliency/srvdrivennewgroup

Context:
There is a regression that I've let agent fix Azure/typespec-azure#4386
This may affect e2e tests of https://github.com/Azure/typespec-azure/tree/main/packages/azure-http-specs/specs/resiliency/srv-driven
If it fails, you may have to disable these tests, till fix PR merged.

Copy link
Copy Markdown
Contributor Author

Copilot AI commented May 6, 2026

@copilot please revert the code change and just skip this test: test/azure-http-specs/resiliency/srvdrivennewgroup

Context:
...

Reverted the @typespec/http-specs version bump and added t.Skip("https://github.com/Azure/typespec-azure/pull/4386") to all 7 tests in test/azure-http-specs/resiliency/srvdrivennewgroup. See commit 04c2c82.

Copilot AI changed the title Upgrade @typespec/http-specs to 0.1.0-alpha.37-dev.5 Skip srvdrivennewgroup tests pending upstream fix May 6, 2026
Copilot AI requested a review from JiaqiZhang-Dev May 6, 2026 03:10
Agent-Logs-Url: https://github.com/Azure/autorest.go/sessions/7679fbe2-498a-4f1f-87ee-f022038d169c

Co-authored-by: JiaqiZhang-Dev <194873822+JiaqiZhang-Dev@users.noreply.github.com>
Agent-Logs-Url: https://github.com/Azure/autorest.go/sessions/06e4a5e3-17f3-4874-971e-950b34e850a1

Co-authored-by: JiaqiZhang-Dev <194873822+JiaqiZhang-Dev@users.noreply.github.com>
Copilot AI changed the title Skip srvdrivennewgroup tests pending upstream fix Upgrade @typespec/http-specs to 0.1.0-alpha.37-dev.5 May 7, 2026
Copilot AI requested a review from JiaqiZhang-Dev May 7, 2026 06:50
ReleaseHelper added 2 commits May 7, 2026 15:09
@JiaqiZhang-Dev JiaqiZhang-Dev changed the title Upgrade @typespec/http-specs to 0.1.0-alpha.37-dev.5 Fix typesoec-go nightly build failure May 7, 2026
@JiaqiZhang-Dev JiaqiZhang-Dev marked this pull request as ready for review May 7, 2026 07:36
Copilot AI review requested due to automatic review settings May 7, 2026 07:36
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the TypeSpec Go test dependencies and regenerated fixtures to address a typespec-go nightly pipeline failure after upstream @typespec/http-specs changes.

Changes:

  • Bump @typespec/http-specs to 0.1.0-alpha.37-dev.5 and update the lockfile accordingly.
  • Regenerate specialwordsgroup Go test SDK artifacts, adding a new SpecialWordsReservedOperationBodyParamsClient and corresponding fake server wiring.
  • Adjust the XML “text value” PUT test payload to match updated spector mock server expectations.

Reviewed changes

Copilot reviewed 8 out of 9 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
pnpm-lock.yaml Locks the updated @typespec/http-specs (and related snapshot key changes), including its updated Node engine requirement.
packages/typespec-go/package.json Bumps @typespec/http-specs dependency version for the typespec-go package.
packages/typespec-go/test/http-specs/specialwordsgroup/zz_specialwordsreservedoperationbodyparams_client.go Adds generated client for reserved operation body params scenario (WithItems).
packages/typespec-go/test/http-specs/specialwordsgroup/zz_specialwords_client.go Exposes a factory method for the new reserved-operation client from SpecialWordsClient.
packages/typespec-go/test/http-specs/specialwordsgroup/zz_responses.go Adds the response type for WithItems.
packages/typespec-go/test/http-specs/specialwordsgroup/zz_options.go Adds the options type for WithItems.
packages/typespec-go/test/http-specs/specialwordsgroup/fake/zz_specialwordsreservedoperationbodyparams_server.go Adds generated fake server transport for the new client/operation.
packages/typespec-go/test/http-specs/specialwordsgroup/fake/zz_specialwords_server.go Wires the new fake server transport into the top-level SpecialWordsServerTransport.
packages/typespec-go/test/http-specs/payload/xmlgroup/xmlmodelwithtextvalue_client_test.go Updates the PUT test payload content string to match new server behavior.
Files not reviewed (1)
  • pnpm-lock.yaml: Language not supported

Comment thread packages/typespec-go/package.json
@JiaqiZhang-Dev JiaqiZhang-Dev changed the title Fix typesoec-go nightly build failure Fix typespec-go nightly build failure May 7, 2026
Co-authored-by: Copilot <copilot@github.com>
Comment thread packages/typespec-go/package.json Outdated
Copilot AI changed the title Fix typespec-go nightly build failure Skip srvdrivennewgroup tests pending upstream fix May 8, 2026
@JiaqiZhang-Dev JiaqiZhang-Dev changed the title Skip srvdrivennewgroup tests pending upstream fix Fix typespec-go nightly build failure May 8, 2026
@JiaqiZhang-Dev JiaqiZhang-Dev force-pushed the copilot/fix-nightly-build-pipeline branch from 21277fc to 4cba600 Compare May 8, 2026 02:03
Comment thread packages/typespec-go/package.json
@jhendrixMSFT jhendrixMSFT merged commit cc101ab into main May 12, 2026
14 checks passed
@jhendrixMSFT jhendrixMSFT deleted the copilot/fix-nightly-build-pipeline branch May 12, 2026 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants