Draft
Conversation
8 tasks
…not allowing swagger transforms to be applied
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In progress: working description of the WebPubSub API in Cadl.
The goal of creating this Cadl description is to determine whether we have parity with the existing DPG v1.0 generator, which generates WebPubSub from swagger. At this point, only a few operations have been described.
Code generated to .NET Template project from this Cadl description can be found in this PR: Azure/azure-sdk-for-net#29499
Outstanding items:
@summarytag causes a schema_violation error in generated swagger -- need to use@doctag for parameter descriptionshubis a client parameter: Provide a way to indicate that a parameter is a "client parameter" microsoft/typespec#664 -- for now, we are working around this with the swagger transform used in the sdk/webpubsub project.OkResponseinstead ofResponse<200>: Add untemplated OkResponse to cadl.http microsoft/typespec#666@consumesper operation? : Allow adding@producesand@consumesat the operation level microsoft/typespec#665x-ms-error-responsein the Cadl definition?modelto group input parameters, because we cannot add swagger transforms to$refparameters