Remove tests that require User-Agent and x-ms-client-request-id override#415
Remove tests that require User-Agent and x-ms-client-request-id override#415antkmsft wants to merge 2 commits intoAzure:mainfrom
Conversation
|
@mikekistler, @lmazuel could you help clarify what the consistent behavior should be? |
|
I think this is a question for the SDK architects to decide, but I can give my opinion.
|
|
The vast majority of these tests were written during track 1 and have not been updated to reflect our current thinking. This test specifies |
|
Customers should be allowed to override both, but not through Swagger, through Azure-Core features. IOW, I would agree to remove the "User-Agent" parameter from the Swagger, as it should not be necessary to trigger an override. But the test itself checking that people can override the value should stay. |
Please help me to find out the truth: either all SDK should implement conformance to these 2 scenarios, or it should not be allowed - so then the scenarios should be removed, and these SDKs who have logic to make it work probably need to undo the code that they have to enable it.
User-Agent, C++ and Go do not;x-ms-client-request-id, C++ does not.I am having several conversations with people saying that
User-Agentandx-ms-client-request-idoverriding should not be allowed:User-Agentif it is already set azure-sdk-for-go#19890