Skip to content

[Containerapp] az containerapp compose create: Fix TypeError when docker-compose file include env_file without environment #9498

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Greedygre wants to merge 1 commit into
base: main
Choose a base branch
from
+3 −2
Open

[Containerapp] az containerapp compose create: Fix TypeError when docker-compose file include env_file without environment #9498

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/containerapp/HISTORY.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,8 @@ Release History
upcoming
++++++
* 'az containerapp function invocations': Update application insights query
* 'az containerapp function keys': Update minimum replica check
* 'az containerapp function keys': Update minimum replica check
* 'az containerapp compose create': Fix `TypeError` when docker-compose file include `env_file` without `environment`

1.3.0b1
++++++
Expand Down
2 changes: 1 addition & 1 deletion src/containerapp/setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@
]

# TODO: Add any additional SDK dependencies here
DEPENDENCIES = ['pycomposefile>=0.0.29', 'docker', 'kubernetes==24.2.0']
DEPENDENCIES = ['pycomposefile>=0.0.34', 'docker', 'kubernetes==24.2.0']
Copy link

Copilot AI Jan 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The dependency upgrade fixes a TypeError when docker-compose files include env_file without environment, but there appears to be no test coverage for this specific scenario. Consider adding a test case in test_containerapp_compose_environment.py that verifies compose create works correctly when a docker-compose file specifies env_file without an environment section.

Copilot uses AI. Check for mistakes.

# Install pack CLI to build runnable application images from source
_ = get_pack_exec_path()
Expand Down
Loading