[Storage-mover] az storage-mover endpoint create-for-storage-container: Add support for system assigned MI#9510
Conversation
️✔️Azure CLI Extensions Breaking Change Test
|
|
Hi @kartikkhullar, |
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
CodeGen Tools Feedback CollectionThank you for using our CodeGen tool. We value your feedback, and we would like to know how we can improve our product. Please take a few minutes to fill our codegen survey |
|
There was a problem hiding this comment.
Pull request overview
This PR adds automatic system-assigned managed identity configuration to storage blob container endpoints in the Azure CLI storage-mover extension.
Key Changes:
- Adds
"mi_system_assigned": "True"to the arguments dictionary returned by_get_args_for_endpoint_for_storage_container - This automatically enables system-assigned managed identity when creating or updating storage container endpoints
…into azure-sm/blob-to-blob-endpoint-identity-patch
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This reverts commit 395668c.
|
@calvinhzy @evelyn-ys can you guys please confirm an ETA for the review completion. |
|
@evelyn-ys Kindly review and approve the changes. |
az storage-mover endpoint create-for-storage-container: Add system assigned MI
az storage-mover endpoint create-for-storage-container: Add system assigned MIaz storage-mover endpoint create-for-storage-container: Add support for system assigned MI
|
[Release] Update index.json for extension [ storage-mover-1.2.1 ] : https://dev.azure.com/msazure/One/_build/results?buildId=151053931&view=results |
* Storage Container Endpoint Identity Patch * Updated test and added History * updated API versions in test recordings * Update src/storage-mover/HISTORY.rst Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update src/storage-mover/azext_storage_mover/custom.py Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Revert "Update src/storage-mover/azext_storage_mover/custom.py" This reverts commit 395668c. --------- Co-authored-by: KARTIK KHULLAR <kkhullar@microsoft.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally? (pip install wheel==0.30.0required)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.