Skip to content

[Storage-mover] az storage-mover endpoint create-for-storage-container: Add support for system assigned MI#9510

Merged
calvinhzy merged 7 commits into
Azure:mainfrom
kartikkhullar:azure-sm/blob-to-blob-endpoint-identity-patch
Jan 29, 2026
Merged

[Storage-mover] az storage-mover endpoint create-for-storage-container: Add support for system assigned MI#9510
calvinhzy merged 7 commits into
Azure:mainfrom
kartikkhullar:azure-sm/blob-to-blob-endpoint-identity-patch

Conversation

@kartikkhullar
Copy link
Copy Markdown
Contributor

@kartikkhullar kartikkhullar commented Jan 9, 2026


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

Copilot AI review requested due to automatic review settings January 9, 2026 12:07
@azure-client-tools-bot-prd
Copy link
Copy Markdown

azure-client-tools-bot-prd Bot commented Jan 9, 2026

️✔️Azure CLI Extensions Breaking Change Test
️✔️Non Breaking Changes

@azure-client-tools-bot-prd
Copy link
Copy Markdown

Hi @kartikkhullar,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

@yonzhan
Copy link
Copy Markdown
Collaborator

yonzhan commented Jan 9, 2026

Thank you for your contribution! We will review the pull request and get back to you soon.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jan 9, 2026

The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR.

Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions).
After that please run the following commands to enable git hooks:

pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jan 9, 2026

CodeGen Tools Feedback Collection

Thank you for using our CodeGen tool. We value your feedback, and we would like to know how we can improve our product. Please take a few minutes to fill our codegen survey

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jan 9, 2026

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds automatic system-assigned managed identity configuration to storage blob container endpoints in the Azure CLI storage-mover extension.

Key Changes:

  • Adds "mi_system_assigned": "True" to the arguments dictionary returned by _get_args_for_endpoint_for_storage_container
  • This automatically enables system-assigned managed identity when creating or updating storage container endpoints

Comment thread src/storage-mover/azext_storage_mover/custom.py Outdated
Comment thread src/storage-mover/azext_storage_mover/custom.py Outdated
Comment thread src/storage-mover/azext_storage_mover/custom.py Outdated
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 5 out of 6 changed files in this pull request and generated 2 comments.

Comment thread src/storage-mover/azext_storage_mover/custom.py
Comment thread src/storage-mover/HISTORY.rst Outdated
kartikkhullar and others added 3 commits January 14, 2026 12:04
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 5 out of 6 changed files in this pull request and generated no new comments.

@rajsnehilpathak123
Copy link
Copy Markdown

@calvinhzy @evelyn-ys can you guys please confirm an ETA for the review completion.

@kartikkhullar
Copy link
Copy Markdown
Contributor Author

@evelyn-ys Kindly review and approve the changes.

@yonzhan yonzhan requested a review from notyashhh January 27, 2026 07:30
@calvinhzy calvinhzy changed the title Storage Container Endpoint Identity Patch [Storage-mover] az storage-mover endpoint create-for-storage-container: Add system assigned MI Jan 29, 2026
@calvinhzy calvinhzy changed the title [Storage-mover] az storage-mover endpoint create-for-storage-container: Add system assigned MI [Storage-mover] az storage-mover endpoint create-for-storage-container: Add support for system assigned MI Jan 29, 2026
@calvinhzy calvinhzy merged commit ab72ddc into Azure:main Jan 29, 2026
28 of 30 checks passed
@azclibot
Copy link
Copy Markdown
Collaborator

[Release] Update index.json for extension [ storage-mover-1.2.1 ] : https://dev.azure.com/msazure/One/_build/results?buildId=151053931&view=results

jepetty pushed a commit to jepetty/azure-cli-extensions that referenced this pull request Feb 11, 2026
* Storage Container Endpoint Identity Patch

* Updated test and added History

* updated API versions in test recordings

* Update src/storage-mover/HISTORY.rst

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* Update src/storage-mover/azext_storage_mover/custom.py

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* Revert "Update src/storage-mover/azext_storage_mover/custom.py"

This reverts commit 395668c.

---------

Co-authored-by: KARTIK KHULLAR <kkhullar@microsoft.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants