{appservice-kube} Remove unused compute SDK client factory and completers by william051200 · Pull Request #9787 · Azure/azure-cli-extensions

william051200 · 2026-04-16T06:31:47Z

During investigation for migrating compute SDK usage to AAZ-based commands, it was found that the compute client factory and related completer code are not referenced anywhere in the extension. Rather than migrating dead code, this PR removes it entirely

This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
My extension version conforms to the Extension version schema

For new extensions:

My extension description/summary conforms to the Extension Summary Guidelines.

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

azure-client-tools-bot-prd · 2026-04-16T06:31:50Z

️✔️Azure CLI Extensions Breaking Change Test

️✔️Non Breaking Changes

yonzhan · 2026-04-16T06:31:59Z

Thank you for your contribution! We will review the pull request and get back to you soon.

azure-pipelines · 2026-04-16T06:32:01Z

Azure Pipelines: Successfully started running 2 pipeline(s).

github-actions · 2026-04-16T06:32:03Z

The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR.

Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions).
After that please run the following commands to enable git hooks:

pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>

azure-pipelines · 2026-04-16T06:33:42Z

Azure Pipelines: Successfully started running 2 pipeline(s).

Copilot

Pull request overview

This PR removes dead compute-related code paths from the appservice-kube extension (compute client factory + VM-size completers), avoiding unnecessary migration work while also bumping the extension patch version.

Changes:

Remove unused compute client factory (cf_compute_service) and VM size helper.
Remove unused argument completers for VM size / SKU.
Bump extension version to 0.1.12 and add a corresponding HISTORY entry.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
`src/appservice-kube/setup.py`	Bumps extension version to 0.1.12.
`src/appservice-kube/azext_appservice_kube/custom.py`	Removes unused `get_vm_sizes` helper.
`src/appservice-kube/azext_appservice_kube/_completers.py`	Removes unused completer implementations (file now effectively empty).
`src/appservice-kube/azext_appservice_kube/_client_factory.py`	Removes unused compute mgmt client factory.
`src/appservice-kube/HISTORY.rst`	Adds 0.1.12 changelog entry (currently mismatched with the actual PR changes).

Copilot · 2026-04-16T06:34:08Z

+0.1.12
++++++
+* Remove unused completer


The 0.1.12 release note says this PR migrates compute operations to AAZ, but the actual change set is removing unused compute client factory/completer code. Please update the HISTORY entry to accurately reflect the user-visible change (e.g., removal of unused compute completers/client factory) to avoid misleading extension consumers.

azure-pipelines · 2026-04-16T06:34:24Z

Azure Pipelines: Successfully started running 2 pipeline(s).

github-actions · 2026-04-16T06:35:19Z

For more info about extension versioning, please refer to Extension version schema

yanzhudd · 2026-05-15T07:17:36Z

-
-
-@Completer
-def get_vm_size_completion_list(cmd, prefix, namespace):    # pylint: disable=unused-argument


Are the these completers being used anywhere?

No, not seeing any import for this

yanzhudd · 2026-05-15T07:19:25Z

 # TODO: Confirm this is the right version number you want and it matches your
 # HISTORY.rst entry.
-VERSION = '0.1.11'
+VERSION = '1.0.0b1'


since this is just a minor change, it would be better to upgrade to 0.1.12

…tion

Copilot

Pull request overview

Copilot reviewed 6 out of 9 changed files in this pull request and generated 2 comments.

+        # `--is-kube` still uses the old dict-of-strings shape.
+        # {"linux": [...], "windows": [...]}


+    @AllowLargeResponse()
+    @ResourceGroupPreparer(location="malaysiawest")
    def test_win_webapp_quick_create_kube(self, resource_group):
        webapp_name = self.create_random_name(prefix='webapp-quick', length=24)
        plan = self.create_random_name(prefix='plan-quick', length=24)


…tion

william051200 added 5 commits April 16, 2026 13:18

Migrate code

b01d010

Update version

79ee8b0

Update history message

5fb1cb5

Remove code due to not being use in this package

2cfd4a4

Update history message

4da2b28

william051200 requested review from Juliehzl and howang-ms as code owners April 16, 2026 06:31

Copilot AI review requested due to automatic review settings April 16, 2026 06:31

azure-client-tools-bot-prd Bot added this to the May 2026 (2026-05-05) milestone Apr 16, 2026

william051200 self-assigned this Apr 16, 2026

microsoft-github-policy-service Bot requested review from jsntcy, yanzhudd, yonzhan and zhoxing-ms April 16, 2026 06:32

microsoft-github-policy-service Bot added the Auto-Assign Auto assign by bot label Apr 16, 2026

microsoft-github-policy-service Bot assigned zhoxing-ms Apr 16, 2026

microsoft-github-policy-service Bot added App Services Web Apps extension/webapp labels Apr 16, 2026

Copilot started reviewing on behalf of william051200 April 16, 2026 06:32 View session

Update history message

a3c4042

Copilot AI reviewed Apr 16, 2026

View reviewed changes

github-actions Bot added the release-version-block Updates do not qualify release version rules. NOTE: please do not edit it manually. label Apr 16, 2026

yonzhan assigned yanzhudd and unassigned zhoxing-ms Apr 16, 2026

william051200 added 2 commits April 16, 2026 15:11

Update version

e10b8c8

Update test case and recording

2963925

github-actions Bot removed the release-version-block Updates do not qualify release version rules. NOTE: please do not edit it manually. label Apr 17, 2026

yanzhudd reviewed May 15, 2026

View reviewed changes

Update version

0283246

github-actions Bot added the release-version-block Updates do not qualify release version rules. NOTE: please do not edit it manually. label May 19, 2026

william051200 added 2 commits May 20, 2026 14:13

Merge remote-tracking branch 'origin/main' into appservice-kube-migra…

67be06c

…tion

Update test case and recording

29f7d0b

william051200 requested a review from Copilot May 21, 2026 02:41

Copilot started reviewing on behalf of william051200 May 21, 2026 02:45 View session

Copilot AI reviewed May 21, 2026

View reviewed changes

william051200 added 4 commits May 21, 2026 10:52

Update comment

14bf8e3

Merge remote-tracking branch 'origin/main' into appservice-kube-migra…

ab6ecd5

…tion

Merge remote-tracking branch 'origin/main' into appservice-kube-migra…

e564fac

…tion

Update code

b79e0c5

github-actions Bot removed the release-version-block Updates do not qualify release version rules. NOTE: please do not edit it manually. label May 25, 2026



		@Completer
		def get_vm_size_completion_list(cmd, prefix, namespace): # pylint: disable=unused-argument

		# `--is-kube` still uses the old dict-of-strings shape.
		# {"linux": [...], "windows": [...]}

Conversation

william051200 commented Apr 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Related command

General Guidelines

About Extension Publish

Uh oh!

azure-client-tools-bot-prd Bot commented Apr 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

yonzhan commented Apr 16, 2026

Uh oh!

azure-pipelines Bot commented Apr 16, 2026

Uh oh!

github-actions Bot commented Apr 16, 2026

Uh oh!

azure-pipelines Bot commented Apr 16, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Apr 16, 2026

Choose a reason for hiding this comment

Uh oh!

azure-pipelines Bot commented Apr 16, 2026

Uh oh!

github-actions Bot commented Apr 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

yanzhudd May 15, 2026

Choose a reason for hiding this comment

Uh oh!

william051200 May 19, 2026

Choose a reason for hiding this comment

Uh oh!

yanzhudd May 15, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

william051200 commented Apr 16, 2026 •

edited

Loading

azure-client-tools-bot-prd Bot commented Apr 16, 2026 •

edited

Loading

github-actions Bot commented Apr 16, 2026 •

edited

Loading