[aks-preview] Add --node-public-ip-prefix-ids for dual-stack ILPIP support by christine33-creator · Pull Request #9828 · Azure/azure-cli-extensions

christine33-creator · 2026-04-28T18:01:29Z

Add a new CLI parameter --node-public-ip-prefix-ids (comma-separated list of public IP prefix resource IDs) to 'az aks create' and 'az aks nodepool add' for dual-stack instance-level public IPs (IPv4 and/or IPv6).

Register parameter in _params.py for aks create and nodepool add
Add mutual exclusion validator with --node-public-ip-prefix-id (singular)
Wire parameter through custom.py function signatures
Add get_node_public_ip_prefix_ids() context method in agentpool_decorator
Set network_profile.node_public_ip_prefix_ids on the SDK model
Auto-enable enable_node_public_ip when prefix IDs are provided
Add node_public_ip_prefix_ids field to vendored AgentPoolNetworkProfile
Add unit tests for the new context method
Not added to nodepool update (field is immutable on existing pools)

This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

az aks create
az aks nodepool add

General Guidelines

Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
My extension version conforms to the Extension version schema

For new extensions:

My extension description/summary conforms to the Extension Summary Guidelines.

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

azure-client-tools-bot-prd · 2026-04-28T18:01:33Z

❌Azure CLI Extensions Breaking Change Test

❌aks-preview

rule cmd_name rule_message suggest_message

❌ 1010 - ParaPropUpdate aks nodepool add cmd aks nodepool add update parameter spot_max_price: updated property default from nan to nan please change property default from nan to nan for parameter spot_max_price of cmd aks nodepool add

⚠️ 1006 - ParaAdd aks create cmd aks create added parameter node_public_ip_prefix_ids

⚠️ 1006 - ParaAdd aks nodepool add cmd aks nodepool add added parameter node_public_ip_prefix_ids

azure-client-tools-bot-prd · 2026-04-28T18:01:36Z

Hi @christine33-creator,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

yonzhan · 2026-04-28T18:01:41Z

Thank you for your contribution! We will review the pull request and get back to you soon.

github-actions · 2026-04-28T18:01:43Z

The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR.

Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions).
After that please run the following commands to enable git hooks:

pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>

github-actions · 2026-04-28T18:02:49Z

CodeGen Tools Feedback Collection

Thank you for using our CodeGen tool. We value your feedback, and we would like to know how we can improve our product. Please take a few minutes to fill our codegen survey

github-actions · 2026-04-28T18:05:23Z

For more info about extension versioning, please refer to Extension version schema

Copilot

Pull request overview

This PR adds dual-stack instance-level public IP prefix support to the aks-preview extension by introducing a new --node-public-ip-prefix-ids option (comma-separated list) for az aks create and az aks nodepool add, and wiring it through the agent pool construction path and vendored SDK model.

Changes:

Add --node-public-ip-prefix-ids argument (and mutual exclusion with --node-public-ip-prefix-id) for aks create and aks nodepool add.
Parse the comma-separated value in the agentpool context and set agentpool.network_profile.node_public_ip_prefix_ids, auto-enabling node public IP when set.
Vendor the new AgentPoolNetworkProfile.node_public_ip_prefix_ids field, bump extension version, update changelog, and add unit tests for parsing.

Reviewed changes

Copilot reviewed 10 out of 10 changed files in this pull request and generated 5 comments.

Show a summary per file

File	Description
`src/aks-preview/setup.py`	Bumps extension version to `20.0.0b5`.
`src/aks-preview/HISTORY.rst`	Adds release notes for the new CLI parameter.
`src/aks-preview/azext_aks_preview/_params.py`	Registers `node_public_ip_prefix_ids` for `aks create` and `aks nodepool add` with a validator and help text.
`src/aks-preview/azext_aks_preview/_validators.py`	Adds a mutual-exclusion validator for plural vs singular prefix args.
`src/aks-preview/azext_aks_preview/custom.py`	Extends `aks_create` and `aks_agentpool_add` signatures to accept the new parameter.
`src/aks-preview/azext_aks_preview/agentpool_decorator.py`	Adds parsing context method and decorates the AgentPool network profile with `node_public_ip_prefix_ids`.
`src/aks-preview/azext_aks_preview/vendored_sdks/azure_mgmt_preview_aks/models/_models.py`	Adds `node_public_ip_prefix_ids` to the vendored `AgentPoolNetworkProfile` model.
`src/aks-preview/azext_aks_preview/tests/latest/test_agentpool_decorator.py`	Adds unit tests for the new context parsing method.
`src/aks-preview/azext_aks_preview/tests/latest/test_managed_cluster_decorator.py`	Updates expected params for agentpool setup to include the new key.
`linter_exclusions.yml`	Adds option-length exclusions for the new parameter for relevant commands.

FumingZhang

lgtm

FumingZhang · 2026-05-18T07:29:29Z


+    # live_only: NodePublicIPv6PrefixPreview feature flag must be registered on the
+    # test subscription. Recording-based tests will be added once the feature is GA.
+    @live_only()


can you paste a screenshot or link to the passed test run?

Yes, the live test passes end-to-end against eastus2euap. Pushed some minor changes after I noticed two issues running it live: the RP rejects an IPv6 prefix unless the cluster itself is dual-stack, added --ip-families IPv4,IPv6.
The CLI's output transformer normalizes the SDK wire-format key nodePublicIPPrefixIDs to nodePublicIpPrefixIDs (lowercase p) in the response JSON, so the JMESPath checks were updated to match.

@FumingZhang anything else needed on my end to merge the changes? there are no additional changes incoming from my side.

…pport Add a new CLI parameter --node-public-ip-prefix-ids (comma-separated list of public IP prefix resource IDs) to 'az aks create' and 'az aks nodepool add' for dual-stack instance-level public IPs (IPv4 and/or IPv6). - Register parameter in _params.py for aks create and nodepool add - Add mutual exclusion validator with --node-public-ip-prefix-id (singular) - Wire parameter through custom.py function signatures - Add get_node_public_ip_prefix_ids() context method in agentpool_decorator - Set network_profile.node_public_ip_prefix_ids on the SDK model - Auto-enable enable_node_public_ip when prefix IDs are provided - Add node_public_ip_prefix_ids field to vendored AgentPoolNetworkProfile - Add unit tests for the new context method - Not added to nodepool update (field is immutable on existing pools)

…py entries - Fix help text: 'Requires --enable-node-public-ip' -> 'Automatically enables' - Add --node-public-ip-prefix-ids to _help.py for both aks create and nodepool add - Enhance validator: check non-empty, max 2 IDs, valid resource IDs - Handle empty string in decorator: raise InvalidArgumentValueError - Add unit test for empty string error case

- Revert manual edits to vendored SDK _models.py (AgentPoolNetworkProfile) - Use dictionary-style access (network_profile["nodePublicIPPrefixIDs"]) instead of attribute access, so the field is serialized correctly without requiring the SDK to be re-vendored - Add scenario test test_node_public_ip_prefix_ids covering both aks create and aks nodepool add with dual-stack IP prefixes

The scenario test requires the NodePublicIPv6PrefixPreview feature flag and Azure credentials. Mark it @live_only() so it is skipped during CI recording-based test runs.

The vendored SDK has been updated (PR Azure#9869) to include the nodePublicIPPrefixIDs field on AgentPoolNetworkProfile. Switch from the dictionary-style workaround to direct attribute access on the SDK model per reviewer guidance.

- Add --ip-families IPv4,IPv6 and the AKS-EnableDualStack preview header because the RP rejects an IPv6 prefix unless the cluster is dual-stack (NodePublicIPPrefixIDsRequiresDualStack). - Update JMESPath assertions from nodePublicIPPrefixIDs to nodePublicIpPrefixIDs to match how Azure CLI's output transformer normalizes the SDK wire-format key. Verified end-to-end: live test passes (1 passed in 666.50s).

azclibot · 2026-05-26T03:56:38Z

[Release] Update index.json for extension [ aks-preview-21.0.0b2 ] : https://dev.azure.com/msazure/One/_build/results?buildId=165521019&view=results

azure-client-tools-bot-prd Bot added this to the June 2026 (2026-06-02) milestone Apr 28, 2026

microsoft-github-policy-service Bot requested review from FumingZhang, yanzhudd, yonzhan and zhoxing-ms April 28, 2026 18:02

microsoft-github-policy-service Bot assigned yanzhudd and zhoxing-ms Apr 28, 2026

microsoft-github-policy-service Bot added Auto-Assign Auto assign by bot AKS labels Apr 28, 2026

christine33-creator marked this pull request as ready for review April 28, 2026 20:36

christine33-creator requested a review from kairu-ms as a code owner April 28, 2026 20:36

Copilot AI review requested due to automatic review settings April 28, 2026 20:36

christine33-creator requested a review from wangzelin007 as a code owner April 28, 2026 20:36

Copilot started reviewing on behalf of christine33-creator April 28, 2026 20:37 View session

Copilot AI reviewed Apr 28, 2026

View reviewed changes

yonzhan unassigned zhoxing-ms Apr 28, 2026

FumingZhang reviewed Apr 29, 2026

View reviewed changes

Comment thread src/aks-preview/azext_aks_preview/vendored_sdks/azure_mgmt_preview_aks/models/_models.py Outdated

christine33-creator force-pushed the cdossa/add-node-public-ip-prefix-ids branch from 267c192 to 9f6a330 Compare April 29, 2026 18:36

christine33-creator force-pushed the cdossa/add-node-public-ip-prefix-ids branch from b07ca04 to 2db549e Compare May 7, 2026 20:40

christine33-creator force-pushed the cdossa/add-node-public-ip-prefix-ids branch from 2db549e to f08cba5 Compare May 15, 2026 19:39

FumingZhang reviewed May 18, 2026

View reviewed changes

FumingZhang previously approved these changes May 22, 2026

View reviewed changes

christine33-creator added 2 commits May 25, 2026 11:06

Add linter exclusions for --node-public-ip-prefix-ids option length

61b3a4e

christine33-creator added 6 commits May 25, 2026 11:06

Bump version to 20.0.0b5 and add HISTORY.rst entry

219d4a1

Mark test_node_public_ip_prefix_ids as live_only

fde425a

The scenario test requires the NodePublicIPv6PrefixPreview feature flag and Azure credentials. Mark it @live_only() so it is skipped during CI recording-based test runs.

christine33-creator force-pushed the cdossa/add-node-public-ip-prefix-ids branch from d3abf72 to ec1fe76 Compare May 25, 2026 16:07

Merge branch 'main' into cdossa/add-node-public-ip-prefix-ids

ff38196

FumingZhang dismissed their stale review via ff38196 May 26, 2026 00:54

yanzhudd approved these changes May 26, 2026

View reviewed changes

yanzhudd merged commit 96a4078 into Azure:main May 26, 2026
24 checks passed

Conversation

christine33-creator commented Apr 28, 2026

Related command

General Guidelines

About Extension Publish

Uh oh!

azure-client-tools-bot-prd Bot commented Apr 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

azure-client-tools-bot-prd Bot commented Apr 28, 2026

Uh oh!

yonzhan commented Apr 28, 2026

Uh oh!

github-actions Bot commented Apr 28, 2026

Uh oh!

github-actions Bot commented Apr 28, 2026

CodeGen Tools Feedback Collection

Uh oh!

github-actions Bot commented Apr 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

FumingZhang left a comment

Choose a reason for hiding this comment

Uh oh!

FumingZhang May 18, 2026

Choose a reason for hiding this comment

Uh oh!

christine33-creator May 18, 2026

Choose a reason for hiding this comment

Uh oh!

christine33-creator May 20, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

azclibot commented May 26, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

azure-client-tools-bot-prd Bot commented Apr 28, 2026 •

edited

Loading

github-actions Bot commented Apr 28, 2026 •

edited

Loading