[vm-repair] Update --distro help text to list all supported distros#9899
Open
msaenzbosupport wants to merge 2 commits into
Open
[vm-repair] Update --distro help text to list all supported distros#9899msaenzbosupport wants to merge 2 commits into
msaenzbosupport wants to merge 2 commits into
Conversation
The --distro parameter help text and example only listed a subset of the actually supported distros (rhel7|rhel8|sles12|sles15|ubuntu20|centos7|centos8|oracle7). Updated both _params.py and _help.py to include all distros currently supported in the code (repair_utils.py): - Added: rhel9, rhel10, ubuntu22, ubuntu24, centos6, oracle7, oracle8, oracle9, oracle10 - Also documented that a custom URN (Publisher:Offer:Sku:Version) is accepted
|
Validation for Breaking Change Starting...
Thanks for your contribution! |
|
Hi @msaenzbosupport, |
microsoft-github-policy-service
Bot
requested review from
yanzhudd and
zhoxing-ms
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Updates the --distro argument help and examples for az vm repair create to reflect additional distro options and clarify that a custom URN is supported.
Changes:
- Expanded the documented list of supported distros for
--distro. - Added documentation that a custom URN can be provided for
--distro. - Updated CLI help example to include the expanded distro list.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/vm-repair/azext_vm_repair/_params.py | Expands --distro help text and documents custom URN input format. |
| src/vm-repair/azext_vm_repair/_help.py | Updates the example command to reflect the expanded --distro options. |
| c.argument('enable_nested', help='enable nested hyperv.') | ||
| c.argument('associate_public_ip', help='Option to create a repair vm with a public ip. If this parameter is not used, only a private ip will be made.') | ||
| c.argument('distro', help='Option to create repair vm from a specific linux distro (rhel7|rhel8|sles12|sles15|ubuntu20|centos7|centos8|oracle7)') | ||
| c.argument('distro', help='Option to create repair vm from a specific linux distro (rhel7|rhel8|rhel9|rhel10|ubuntu20|ubuntu22|ubuntu24|centos6|centos7|centos8|oracle7|oracle8|oracle9|oracle10|sles12|sles15). A custom URN can also be provided in the format Publisher:Offer:Sku:Version.') |
| - name: Create a repair VM of a specific distro or a specific URN could also be provided | ||
| text: > | ||
| az vm repair create -g MyResourceGroup -n myVM --distro 'rhel7|sles12|ubuntu20|centos6|oracle8|sles15' | ||
| az vm repair create -g MyResourceGroup -n myVM --distro 'rhel7|rhel8|rhel9|rhel10|ubuntu20|ubuntu22|ubuntu24|centos6|centos7|centos8|oracle7|oracle8|oracle9|oracle10|sles12|sles15' |
Collaborator
|
vm-repair |
… fix examples - Added HISTORY.rst entry for version 2.2.1 - Bumped version in setup.py from 2.2.0 to 2.2.1 - Split distro example into two: one with a concrete distro keyword (rhel9), and another showing custom URN format (Publisher:Offer:Sku:Version) - Addresses Copilot review comment about pipe-delimited example being misleading
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The
--distroparameter help text in_params.pyand the example in_help.pyonly listed a subset of the actually supported distros:rhel7|rhel8|sles12|sles15|ubuntu20|centos7|centos8|oracle7However, the code in
repair_utils.py(functions_select_distro_linux,_select_distro_linux_gen2, and_select_distro_linux_Arm64) supports many more:rhel7|rhel8|rhel9|rhel10|ubuntu20|ubuntu22|ubuntu24|centos6|centos7|centos8|oracle7|oracle8|oracle9|oracle10|sles12|sles15Changes
_params.py: Updated the--distroargument help string to include all supported distros and documented that a custom URN (Publisher:Offer:Sku:Version) is also accepted._help.py: Updated the example command to show all available distro keywords.Testing
Documentation-only change. No functional code modified.