Fix horizon test to correct build failure#9902
Open
nasc17 wants to merge 1 commit into
Open
Conversation
|
Validation for Breaking Change Starting...
Thanks for your contribution! |
|
Hi @nasc17, |
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
This PR removes a hard-coded admin password in HorizonDB CLI scenario tests by generating a per-run password and introducing a shared password prefix constant.
Changes:
- Add
PASSWORD_PREFIXto the test constants module. - Generate
admin_passwordviacreate_random_name(...)instead of using a fixed literal. - Update test import list to include
PASSWORD_PREFIX.
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/horizondb/azext_horizondb/tests/latest/test_horizondb_commands.py | Switches admin password from a fixed value to a generated value using a shared prefix. |
| src/horizondb/azext_horizondb/tests/latest/constants.py | Introduces PASSWORD_PREFIX for reuse across tests. |
| cluster_name = self.create_random_name(CLUSTER_NAME_PREFIX, CLUSTER_NAME_MAX_LENGTH) | ||
| admin_user = 'horizonadmin' | ||
| admin_password = 'H0riz0nP@ssw0rd!' | ||
| admin_password = self.create_random_name(PASSWORD_PREFIX, 20) |
|
|
||
| # Constants | ||
| CLUSTER_NAME_PREFIX = 'horizondbclitest-' | ||
| PASSWORD_PREFIX = 'passwordHorizon%' |
Collaborator
|
horizon |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally? (pip install wheel==0.30.0required)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.