remove depericated --location#9903
Draft
s-ddavydenko wants to merge 1 commit into
Draft
Conversation
|
Validation for Breaking Change Starting...
Thanks for your contribution! |
Collaborator
|
quantum |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes the deprecated
--location/-lparameter fromaz quantum jobcommands. Job operations now derive the workspace location from the active workspace (set viaaz quantum workspace set) instead of accepting an independent, easily-mismatched value from the user.Motivation
--locationonaz quantum jobwas redundant — the location is already an intrinsic property of the target workspace. Allowing it to be passed independently meant a user could specify a region that didn't match their workspace, producing confusing failures downstream. The parameter was already marked deprecated and scheduled for removal.Changes
--location/-lfromaz quantum jobcommand definitions and from the underlyingoperations/job.pyfunctions.--location.input_paramsdict; a local copy is used when defaults need to be injected.setup.py; added entry toHISTORY.rst.Testing
src/quantum/azext_quantum/tests/latestpass locally (pytest).test_jobsexercised against a personal Azure Quantum workspace viaAZURE_QUANTUM_*env vars; submit / list / show / cancel succeed without--location.test_submit*,test_workspace_create_destroy,test_workspace_keys,test_get_provider,test_workspace,test_targets) are pre-existing and unrelated to this change:AttributeError: 'QuantumWorkspace' object has no attribute 'providers'— SDK drift inoperations/workspace.py(the regenerated SDK movedprovidersontoworkspace.properties.providers).e2e-scenarios/qw-e2e-tests-eus) hard-coded intests/latest/utils.pythat isn't accessible from a personal subscription.Both reproduce on
main.