{AFD} Fix Issue 31584: make location parameter as unrequired.#31588
Merged
Conversation
added 2 commits
June 2, 2025 12:12
Ptnan7
requested review from
jsntcy,
kairu-ms,
necusjz and
wangzelin007
as code owners
️✔️AzureCLI-FullTest
|
Collaborator
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
| rule | cmd_name | rule_message | suggest_message |
|---|---|---|---|
| afd profile identity | sub group afd profile identity added |
||
| cdn endpoint update | cmd cdn endpoint update update parameter query_string_caching_behavior: added property aaz_default=None |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes Issue 31584 by making the location parameter optional for AFD commands and updates the API version strings from "2024-09-01" to "2025-04-15" across multiple commands. Additionally, it refactors some internal conditional logic and renames inner classes within the listing operations.
Reviewed Changes
Copilot reviewed 16 out of 16 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/azure-cli/azure/cli/command_modules/cdn/custom/custom_afdx.py | Sets location parameter as unrequired. |
| src/azure-cli/azure/cli/command_modules/cdn/aaz/latest/afd/profile/log_scrubbing/_show.py | Updates API version in command info and query parameters. |
| src/azure-cli/azure/cli/command_modules/cdn/aaz/latest/afd/profile/identity/_wait.py | Introduces new Wait command for profile identity. |
| src/azure-cli/azure/cli/command_modules/cdn/aaz/latest/afd/profile/identity/_show.py | Updates API version and adds subresource selector logic. |
| src/azure-cli/azure/cli/command_modules/cdn/aaz/latest/afd/profile/identity/init.py src/azure-cli/azure/cli/command_modules/cdn/aaz/latest/afd/profile/identity/__cmd_group.py |
Adds/imports module definitions. |
| src/azure-cli/azure/cli/command_modules/cdn/aaz/latest/afd/profile/_wait.py, _update.py, _show.py, _list.py, _delete.py, _create.py |
Updates API versions and adjusts the command execution/argument logic. |
Comment on lines
+55
to
+58
| condition_1 = has_value(self.ctx.subscription_id) and has_value(self.ctx.args.resource_group) is not True | ||
| if condition_0: | ||
| self.ProfilesList(ctx=self.ctx)() | ||
| if condition_1: | ||
| self.ProfilesListByResourceGroup(ctx=self.ctx)() | ||
| if condition_1: |
There was a problem hiding this comment.
The updated conditional logic in the ProfilesList operation appears to be inverted; please verify that the conditions correctly differentiate between listing by subscription and by resource group.
| return result, next_link | ||
|
|
||
| class ProfilesList(AAZHttpOperation): | ||
| class ProfilesListByResourceGroup(AAZHttpOperation): |
There was a problem hiding this comment.
The renaming of the inner classes (ProfilesList and ProfilesListByResourceGroup) appears to be swapped; please ensure that the class names correctly represent their intended functionality.
Suggested change
| class ProfilesListByResourceGroup(AAZHttpOperation): | |
| class ProfilesList(AAZHttpOperation): |
Member
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
Member
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
necusjz
approved these changes
Jun 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#31584