{Network} Revert StandardV2 for NAT Gateway and Public IP#31589
Merged
necusjz merged 1 commit intoJun 3, 2025
Conversation
This reverts commit 1f27224.
necusjz
requested review from
AllyW,
FumingZhang,
jsntcy,
kairu-ms,
wangzelin007,
yanzhudd and
zhoxing-ms
as code owners
️✔️AzureCLI-FullTest
|
❌AzureCLI-BreakingChangeTest
Please submit your Breaking Change Pre-announcement ASAP if you haven't already. Please note:
|
Collaborator
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR reverts the changes introduced in azure-cli#31532 by restoring the previous API version settings and removing the recently added “StandardV2” SKU and IPv6–related properties across the public IP and NAT gateway modules. Key changes include:
- Reverting API versions from 2024-based to versions such as 2022-09-01, 2022-11-01, and 2022-01-01.
- Removing support for “StandardV2” in SKU enum parameters.
- Eliminating IPv6–related properties from schemas in public IP and NAT gateway operations.
Reviewed Changes
Copilot reviewed 141 out of 141 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/azure-cli/azure/cli/command_modules/network/aaz/latest/network/public_ip/prefix/_show.py | API version reverted and IPv6 properties removed. |
| src/azure-cli/azure/cli/command_modules/network/aaz/latest/network/public_ip/prefix/_list.py | API version reversion and condition logic adjustments. |
| src/azure-cli/azure/cli/command_modules/network/aaz/latest/network/public_ip/_create.py | API version reversion and removal of “StandardV2” SKU support. |
| src/azure-cli/azure/cli/command_modules/network/aaz/latest/network/public_ip/_update.py | API version reversion and SKU enum update. |
| src/azure-cli/azure/cli/command_modules/network/nat/gateway/* | API versions reverted for NAT gateway operations. |
| src/azure-cli/azure/cli/command_modules/monitor/tests/latest/recordings/* & ACS tests | Recorded test URIs updated to the reverted API versions. |
Comments suppressed due to low confidence (6)
src/azure-cli/azure/cli/command_modules/network/aaz/latest/network/public_ip/prefix/_show.py:263
- The removal of the IPv6-related property 'public_ip_addresses_v6' should be validated to ensure that no dependent functionality is inadvertently affected.
properties.public_ip_addresses_v6 = AAZListType(... removed)
src/azure-cli/azure/cli/command_modules/network/aaz/latest/network/public_ip/prefix/_show.py:25
- Reverting the API version to '2022-09-01' should be verified against the service documentation to ensure that it aligns with the supported API for public IP prefixes.
"version": "2022-09-01",
src/azure-cli/azure/cli/command_modules/network/aaz/latest/network/public_ip/prefix/_list.py:54
- Confirm that the updated condition ordering correctly distinguishes between the two list operations based on the presence of the resource group and subscription ID.
condition_0 = has_value(self.ctx.args.resource_group) and has_value(self.ctx.subscription_id)
src/azure-cli/azure/cli/command_modules/network/aaz/latest/network/public_ip/_create.py:400
- The removal of the 'StandardV2' option from the SKU enum appears intentional; please ensure that downstream logic and tests are updated accordingly.
enum={"Standard": "Standard"},
src/azure-cli/azure/cli/command_modules/network/aaz/latest/network/public_ip/_update.py:434
- Ensure that removing 'StandardV2' from the SKU enum in the update command is consistent across all public IP commands and that corresponding tests are updated.
enum={"Standard": "Standard"},
src/azure-cli/azure/cli/command_modules/network/aaz/latest/network/nat/gateway/_wait.py:23
- Confirm that reverting the NAT gateway API version to '2022-01-01' aligns with current service expectations and that all related operations function correctly.
["mgmt-plane", "/subscriptions/{}/resourcegroups/{}/providers/microsoft.network/natgateways/{}", "2022-01-01"],
microsoft-github-policy-service
Bot
added
the
Network
kairu-ms
approved these changes
Jun 3, 2025
zhoxing-ms
approved these changes
Jun 3, 2025
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #31532