Skip to content

regression test fix #31608

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Sruuujaaan wants to merge 11 commits into from
Closed

regression test fix #31608

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
24b4937
[Identity] Add support for claims matching expressions with 2025-01-3…
sbandarkar May 8, 2025
516d2f3
revert changes made to az identity commands
sbandarkar May 8, 2025
c834735
Adding examples for CME scenario and some other nit fixes
sbandarkar May 9, 2025
d9996f2
Removed now redundant all help text related to federated-credentials …
sbandarkar May 9, 2025
834fcd4
cleaned up all the legacy federated credential implementation; fix pr…
sbandarkar May 9, 2025
3cb39af
Fix --identity-name --name interchange issue
sbandarkar May 9, 2025
96a9fc3
Removed Resource Id Arguments grouping
sbandarkar May 9, 2025
3c49266
Update federated-credential test suite
sbandarkar May 13, 2025
d71b261
Added tests for Claims Matching Expression scenario
sbandarkar May 13, 2025
b48708c
Merge branch 'Azure:dev' into sban/feature_flexibleFIC_5_9
Sruuujaaan Jun 5, 2025
7ad3580
Fixed Bug #31598
sbandarkar Jun 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions ...li/azure/cli/command_modules/identity/aaz/latest/identity/federated_credential/_create.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,6 +88,7 @@ def _build_arguments_schema(cls, *args, **kwargs):
options=["--audiences"],
arg_group="Properties",
help="The aud value in the token sent to Azure for getting the user-assigned managed identity token. The value configured in the federated credential and the one in the incoming token must exactly match for Azure to issue the access token.",
default=["api://AzureADTokenExchange"],
Copy link

Copilot AI Jun 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The default audience string is duplicated in two places. Consider extracting it into a shared constant (e.g., DEFAULT_AUDIENCES) to avoid magic literals and simplify future updates.

Suggested change
default=["api://AzureADTokenExchange"],
default=DEFAULT_AUDIENCES,

Copilot uses AI. Check for mistakes.
)
_args_schema.issuer = AAZStrArg(
options=["--issuer"],
Expand Down
1 change: 1 addition & 0 deletions ...li/azure/cli/command_modules/identity/aaz/latest/identity/federated_credential/_update.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,6 +90,7 @@ def _build_arguments_schema(cls, *args, **kwargs):
options=["--audiences"],
arg_group="Properties",
help="The aud value in the token sent to Azure for getting the user-assigned managed identity token. The value configured in the federated credential and the one in the incoming token must exactly match for Azure to issue the access token.",
default=["api://AzureADTokenExchange"],
Copy link

Copilot AI Jun 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The default audience string is duplicated in two files. Consider extracting it into a shared constant to reduce duplication and ease maintenance.

Suggested change
default=["api://AzureADTokenExchange"],
default=[DEFAULT_AUDIENCE],

Copilot uses AI. Check for mistakes.
)
_args_schema.issuer = AAZStrArg(
options=["--issuer"],
Expand Down
Loading