[Network] az network application-gateway create/update: Add parameter --enable-fips#32339
Merged
Conversation
necusjz
requested review from
jsntcy,
kairu-ms and
wangzelin007
as code owners
️✔️AzureCLI-FullTest
|
azure-client-tools-bot-prd
Bot
added this to the
November 2025 (2025-11-18)❗ Breaking change release ❗ milestone
|
Hi @necusjz, |
|
| rule | cmd_name | rule_message | suggest_message |
|---|---|---|---|
| network application-gateway create | cmd network application-gateway create added parameter enable_fips |
||
| network application-gateway update | cmd network application-gateway update added parameter enable_fips |
Collaborator
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for the --enable-fips parameter to the az network application-gateway create and az network application-gateway update commands, allowing users to enable or disable FIPS mode on application gateways.
- Adds the
--enable-fipsparameter to application gateway creation and update operations - Updates the ARM template builder to handle the new FIPS configuration property
- Modifies test cases to use explicit network resources and validate FIPS functionality
Reviewed Changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| _params.py | Adds the --enable-fips parameter definition with help text |
| custom.py | Updates function signature to accept the enable_fips parameter |
| _template_builder.py | Implements logic to include enableFips in the application gateway properties |
| _update.py | Adds schema definition for the --enable-fips argument and property mapping |
| test_network_commands.py | Updates test to explicitly create network resources and verify FIPS behavior |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
kairu-ms
approved these changes
Oct 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related command
Description
resolve: #32293
due to https://learn.microsoft.com/en-us/azure/application-gateway/quick-create-cli#create-network-resources and https://learn.microsoft.com/en-us/azure/application-gateway/migrate-v1-v2, we have to modify the test case.
Testing Guide
History Notes
[Component Name 1] BREAKING CHANGE:
az command a: Make some customer-facing breaking change[Component Name 2]
az command b: Add some customer-facing featureThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.