[lab] Fix #7903 Help updated (az lab vm): Add double quotes with escape character to --expand#32354
Conversation
Adding double quotes with escape character, to avoid issue with documentation when user copy/paste the command.
️✔️AzureCLI-FullTest
|
️✔️AzureCLI-BreakingChangeTest
|
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
There was a problem hiding this comment.
Pull Request Overview
This PR updates the help text examples for the --expand parameter in three Azure DevTest Lab VM commands by adding escaped double quotes around the example values. The change modifies the example from 'properties($expand=...)' to '\"properties($expand=...)\"'.
- Updated help text formatting for the
--expandparameter example - Applied consistently across three VM-related command files
- Added escaped double quotes to the query example value
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
src/azure-cli/azure/cli/command_modules/lab/aaz/latest/lab/vm/_wait.py |
Updated --expand help text example with escaped double quotes |
src/azure-cli/azure/cli/command_modules/lab/aaz/latest/lab/vm/_show.py |
Updated --expand help text example with escaped double quotes |
src/azure-cli/azure/cli/command_modules/lab/aaz/latest/lab/vm/_list.py |
Updated --expand help text example with escaped double quotes |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
--expand
|
/azp run |
|
Commenter does not have sufficient privileges for PR 32354 in repo Azure/azure-cli |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
--expandaz lab vm): Add double quotes with escape character to --expand
|
/azp run |
|
Commenter does not have sufficient privileges for PR 32354 in repo Azure/azure-cli |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
The format of the PR title is incorrect. This PR doesn't qualify as a customer-facing change either. It should start with See https://github.com/Azure/azure-cli/tree/dev/doc/authoring_command_modules#submitting-pull-requests |
Add double quotes with escape character, to avoid issue with documentation when user copy/paste the command.
Related command
az lab vm show --helpaz lab vm list --helpaz lab vm wait --helpDescription
This PR is here to fix this issue:
Using az lab vm show to view artifacts doesn't work
The
--expandhelp text have been updated with double quotes to help people when they copy/paste it into their terminal.Testing Guide
Run these commands and look at the output displayed:
az lab vm show --helpaz lab vm list --helpaz lab vm wait --helpBefore:
--expand : Specify the $expand query. Example: 'properties($expand=artifacts,computeVm,networkInterface,applicableSched ule)'.After:
--expand : Specify the $expand query. Example: '"properties($expand=artifacts,computeVm,networkInterface,applicableSchedu le)"'.This checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.