[App Config] az appconfig create/update/feature set: Add support to enable telemetry

src/azure-cli/azure/cli/command_modules/appconfig/_help.py

@@ -38,6 +38,8 @@
     text: az appconfig create -g MyResourceGroup -n MyAppConfiguration -l westus --sku Standard --kv-revision-retention-period 86400
   - name: Create an App Configuration store linked to an Azure Front Door profile.
     text: az appconfig create -g MyResourceGroup -n MyAppConfiguration -l westus --sku Standard --azure-front-door-profile /subscriptions/<SUBSCRIPTION_ID>/resourceGroups/<RESOURCEGROUP>/providers/Microsoft.Cdn/profiles/<PROFILE_NAME>
+  - name: Create an App Configuration store with an Application Insights resource linked for telemetry collection.
+    text: az appconfig create -g MyResourceGroup -n MyAppConfiguration -l westus --sku Standard --appinsights-resource /subscriptions/<SUBSCRIPTIONID>/resourceGroups/<RESOURCEGROUP>/providers/microsoft.insights/components/MyAppInsights
 """
 
 helps['appconfig list-deleted'] = """
@@ -420,6 +422,10 @@
     text: az appconfig update -g MyResourceGroup -n MyAppConfiguration --azure-front-door-profile /subscriptions/<SUBSCRIPTION_ID>/resourceGroups/<RESOURCEGROUP>/providers/Microsoft.Cdn/profiles/<PROFILE_NAME>
   - name: Update an App Configuration store to unlink an Azure Front Door profile.
     text: az appconfig update -g MyResourceGroup -n MyAppConfiguration --azure-front-door-profile ""
+  - name: Link an Application Insights resource to an App Configuration store for telemetry collection.
+    text: az appconfig update -g MyResourceGroup -n MyAppConfiguration --appinsights-resource /subscriptions/<SUBSCRIPTIONID>/resourceGroups/<RESOURCEGROUP>/providers/microsoft.insights/components/MyAppInsights
+  - name: Unlink Application Insights from an App Configuration store.
+    text: az appconfig update -g MyResourceGroup -n MyAppConfiguration --appinsights-resource ""
 """
 
 helps['appconfig feature'] = """
@@ -446,6 +452,12 @@
         - name: Set a feature flag with name "Beta" and custom key ".appconfig.featureflag/MyApp1:Beta" with tags "tag1=value1" and "tag2=value2".
           text:
             az appconfig feature set -n MyAppConfiguration --feature Beta --key .appconfig.featureflag/MyApp1:Beta --tags tag1=value1 tag2=value2
+        - name: Set a feature flag with telemetry enabled.
+          text:
+            az appconfig feature set -n MyAppConfiguration --feature color --telemetry-enabled
+        - name: Disable telemetry on a feature flag.
+          text:
+            az appconfig feature set -n MyAppConfiguration --feature color --telemetry-enabled false
     """
 
 helps['appconfig feature delete'] = """

src/azure-cli/azure/cli/command_modules/appconfig/_params.py

@@ -189,6 +189,7 @@ def load_arguments(self, _):
         c.argument('no_replica', help='Proceed without replica creation for premium tier store.', arg_type=get_three_state_flag())
         c.argument('arm_auth_mode', arg_type=arm_auth_mode_arg_type)
         c.argument('enable_arm_private_network_access', arg_type=enable_arm_private_network_access_arg_type)
+        c.argument('appinsights_resource', help='Resource ID of the Application Insights resource to link with this App Configuration store.')
         c.argument('kv_revision_retention_period', arg_type=kv_revision_retention_period_arg_type)
         c.argument('azure_front_door_profile', help='Resource ID of an Azure Front Door profile to link to this App Configuration store.', is_preview=True)
 
@@ -201,6 +202,7 @@ def load_arguments(self, _):
         c.argument('enable_purge_protection', options_list=['--enable-purge-protection', '-p'], arg_type=get_three_state_flag(), help='Property specifying whether protection against purge is enabled for this App Configuration store. Setting this property to true activates protection against purge for this App Configuration store and its contents. Enabling this functionality is irreversible.')
         c.argument('arm_auth_mode', arg_type=arm_auth_mode_arg_type)
         c.argument('enable_arm_private_network_access', arg_type=enable_arm_private_network_access_arg_type)
+        c.argument('appinsights_resource', help='Resource ID of the Application Insights resource to link with this App Configuration store.')
         c.argument('kv_revision_retention_period', arg_type=kv_revision_retention_period_arg_type)
         c.argument('azure_front_door_profile', help='Resource ID of an Azure Front Door profile to link to this App Configuration store. Pass "" to unlink a Front Door profile.', is_preview=True)
 
@@ -376,6 +378,7 @@ def load_arguments(self, _):
         c.argument('key', validator=validate_feature_key, help='Key of the feature flag. Key must start with the ".appconfig.featureflag/" prefix. Key cannot contain the "%" character. Default key is the reserved prefix ".appconfig.featureflag/" + feature name.')
         c.argument('requirement_type', arg_type=get_enum_type([FeatureFlagConstants.REQUIREMENT_TYPE_ALL, FeatureFlagConstants.REQUIREMENT_TYPE_ANY]),
                    help='Requirement type determines if filters should use "Any" or "All" logic when evaluating the state of a feature.')
+        c.argument('telemetry_enabled', arg_type=get_three_state_flag(), help='Enable or disable telemetry for the feature flag.')
         c.argument('tags', arg_type=tags_type)
 
     with self.argument_context('appconfig feature delete') as c:

src/azure-cli/azure/cli/command_modules/appconfig/custom.py

@@ -25,7 +25,8 @@
                                                 PublicNetworkAccess,
                                                 PrivateLinkDelegation,
                                                 DataPlaneProxyProperties,
-                                                AzureFrontDoorProperties)
+                                                AzureFrontDoorProperties,
+                                                TelemetryProperties)
 from knack.log import get_logger
 from ._utils import resolve_store_metadata, resolve_deleted_store_metadata
 from ._constants import ARMAuthenticationMode, ProvisioningStatus
@@ -55,6 +56,7 @@ def create_configstore(cmd,  # pylint: disable=too-many-locals
                        no_replica=None,  # pylint: disable=unused-argument
                        arm_auth_mode=None,
                        enable_arm_private_network_access=None,
+                       appinsights_resource=None,
                        kv_revision_retention_period=None,
                        azure_front_door_profile=None):
     if assign_identity is not None and not assign_identity:
@@ -76,6 +78,10 @@ def create_configstore(cmd,  # pylint: disable=too-many-locals
     if azure_front_door_profile is not None:
         azure_front_door = AzureFrontDoorProperties(resource_id=azure_front_door_profile if azure_front_door_profile else None)
 
+    telemetry = None
+    if appinsights_resource is not None:
+        telemetry = TelemetryProperties(resource_id=appinsights_resource if appinsights_resource else None)
+
     configstore_params = ConfigurationStore(location=location.lower(),
                                             identity=__get_resource_identity(assign_identity) if assign_identity else None,
                                             sku=Sku(name=sku),
@@ -86,6 +92,7 @@ def create_configstore(cmd,  # pylint: disable=too-many-locals
                                             enable_purge_protection=enable_purge_protection,
                                             create_mode=CreateMode.DEFAULT,
                                             default_key_value_revision_retention_period_in_seconds=kv_revision_retention_period,
+                                            telemetry=telemetry,
                                             data_plane_proxy=DataPlaneProxyProperties(
                                                 authentication_mode=arm_authentication_mode,
                                                 private_link_delegation=arm_private_link_delegation),
@@ -190,6 +197,7 @@ def update_configstore(cmd,  # pylint: disable=too-many-locals
                        enable_purge_protection=None,
                        arm_auth_mode=None,
                        enable_arm_private_network_access=None,
+                       appinsights_resource=None,
                        kv_revision_retention_period=None,
                        azure_front_door_profile=None):
     __validate_cmk(encryption_key_name, encryption_key_vault, encryption_key_version, identity_client_id)
@@ -212,12 +220,17 @@ def update_configstore(cmd,  # pylint: disable=too-many-locals
     if azure_front_door_profile is not None:
         azure_front_door = AzureFrontDoorProperties(resource_id=azure_front_door_profile if azure_front_door_profile else None)
 
+    telemetry = None
+    if appinsights_resource is not None:
+        telemetry = TelemetryProperties(resource_id=appinsights_resource if appinsights_resource else None)
+
     update_params = ConfigurationStoreUpdateParameters(tags=tags,
                                                        sku=Sku(name=sku) if sku else None,
                                                        public_network_access=public_network_access,
                                                        disable_local_auth=disable_local_auth,
                                                        enable_purge_protection=enable_purge_protection,
                                                        default_key_value_revision_retention_period_in_seconds=kv_revision_retention_period,
+                                                       telemetry=telemetry,
                                                        data_plane_proxy=DataPlaneProxyProperties(
                                                            authentication_mode=arm_authentication_mode,
                                                            private_link_delegation=arm_private_link_delegation),

src/azure-cli/azure/cli/command_modules/appconfig/feature.py

@@ -30,24 +30,54 @@
                       convert_keyvalue_to_configurationsetting)
 from ._utils import (get_appconfig_data_client,
                      prep_filter_for_url_encoding,
-                     validate_feature_flag_name)
+                     validate_feature_flag_name,
+                     resolve_store_metadata)
 from ._featuremodels import (map_keyvalue_to_featureflag,
                              map_keyvalue_to_featureflagvalue,
-                             FeatureFilter)
+                             FeatureFilter,
+                             FeatureTelemetry)
 
 
 logger = get_logger(__name__)
 
 # Feature commands #
 
 
+def warn_if_app_insights_not_set(cmd, store_name):
+    """
+    Check if Application Insights resource is set for the App Configuration store.
+    Emits a warning if not set or if the check cannot be completed.
+    """
+    from ._client_factory import cf_configstore
+
+    try:
+        resource_group_name, _ = resolve_store_metadata(cmd, store_name)
+        configstore_client = cf_configstore(cmd.cli_ctx)
+        store = configstore_client.get(resource_group_name, store_name)
+
+        telemetry = getattr(store, "telemetry", None)
+        is_linked = bool(getattr(telemetry, "resource_id", None)) if telemetry else False
+
+        if not is_linked:
+            logger.warning(
+                "App Insights resource for the App Configuration store is not set."
+                "To collect telemetry, connect to an App Insights resource."
+            )
+
+    except Exception as ex:  # pylint: disable=broad-except
+        logger.warning(
+            "Unable to verify App Insights resource for the App Configuration store: %s", str(ex)
+        )
+
+
 def set_feature(cmd,
                 feature=None,
                 key=None,
                 name=None,
                 label=None,
                 description=None,
                 requirement_type=None,
+                telemetry_enabled=None,
                 yes=False,
                 connection_string=None,
                 auth_mode="key",
@@ -84,6 +114,12 @@ def set_feature(cmd,
         FeatureFlagConstants.CONDITIONS: default_conditions
     }
 
+    # Add telemetry if telemetry_enabled is specified
+    if telemetry_enabled is not None:
+        default_value[FeatureFlagConstants.TELEMETRY] = {FeatureFlagConstants.ENABLED: telemetry_enabled}
+        if telemetry_enabled:
+            warn_if_app_insights_not_set(cmd, name)
+
     azconfig_client = get_appconfig_data_client(cmd, name, connection_string, auth_mode, endpoint)
 
     retry_times = 3
@@ -135,6 +171,13 @@ def set_feature(cmd,
                         else FeatureFlagConstants.REQUIREMENT_TYPE_ANY
                     )
 
+                # Update telemetry if telemetry_enabled is specified
+                if telemetry_enabled is not None:
+                    if feature_flag_value.telemetry is None:
+                        feature_flag_value.telemetry = FeatureTelemetry(enabled=telemetry_enabled)
+                    else:
+                        feature_flag_value.telemetry.enabled = telemetry_enabled
+
                 set_kv = KeyValue(key=key,
                                   label=label,
                                   value=json.dumps(feature_flag_value, default=lambda o: {k: v for k, v in o.__dict__.items() if v is not None}, ensure_ascii=False),