{CI} Tighten GHA workflows' permission#33477
Merged
Merged
Conversation
️✔️AzureCLI-FullTest
|
️✔️AzureCLI-BreakingChangeTest
|
Collaborator
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
microsoft-github-policy-service
Bot
requested review from
Pan-Qi,
bebound,
jiasli,
jsntcy,
kairu-ms,
wangzelin007 and
yonzhan
microsoft-github-policy-service
Bot
added
Auto-Assign
naga-nandyala
approved these changes
Jun 1, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR aims to reduce GitHub Actions privilege exposure by replacing pull_request_target with pull_request across several workflows and tightening GITHUB_TOKEN permissions to the minimum required.
Changes:
- Switched multiple workflows from
pull_request_targettopull_request. - Added/adjusted workflow/job-level
permissions(often defaulting to none viapermissions: {}and granting only what a job needs). - Changed
GitHookNoticebehavior from posting a PR comment to only printing the notice in workflow logs.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| .github/workflows/GitHookNotice.yml | Switches to pull_request, scopes permissions, and replaces PR commenting with log output. |
| .github/workflows/CCOA.yml | Switches to pull_request and moves write permissions to the job level for PR commenting. |
| .github/workflows/BlockPRMerge.yml | Switches to pull_request and explicitly removes token permissions. |
| .github/workflows/AzdevStyle.yml | Switches to pull_request (permissions already scoped at job level). |
| .github/workflows/AzdevLinter.yml | Switches to pull_request (permissions already scoped at job level). |
| .github/workflows/AddPRComment.yml | Switches to pull_request while still relying on a repository secret to comment. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
1
to
3
| on: | ||
| pull_request_target: | ||
| pull_request: | ||
| types: [opened] |
Comment on lines
3
to
9
| on: | ||
| pull_request_target: | ||
| pull_request: | ||
| types: | ||
| - opened | ||
| - reopened | ||
| branches: | ||
| - dev |
Comment on lines
+22
to
+26
| - name: Show git hook notice | ||
| run: | | ||
| echo "::group::Git hook notice" | ||
| cat .github/template/git-hooks-note.md | ||
| echo "::endgroup::" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related command
Description
Replaced
pull_request_targetwithpull_requestacross 6 workflows and scoped permissions to the minimum required.Testing Guide
History Notes
[Component Name 1] BREAKING CHANGE:
az command a: Make some customer-facing breaking change[Component Name 2]
az command b: Add some customer-facing featureThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.