Support Custom Exception Provider at Durable Functions Java#3441
Open
nytian wants to merge 1 commit into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds Java-side e2e app scaffolding for validating custom exception properties in Durable Functions failure details, and updates comments to clarify current limitations for non-.NET languages.
Changes:
- Updated the e2e test skip rationale for Java around custom exception properties in
FailureDetails. - Added a Java orchestration + activity that throws a custom exception with various typed properties.
- Clarified
OutOfProcMiddlewarecommentary about why properties may be unavailable in the non-.NET fallback parsing path.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| test/e2e/Tests/Tests/ErrorHandlingTests.cs | Adjusts Java skip comment for the FailureDetails custom-properties test. |
| test/e2e/Apps/BasicJava/src/main/java/com/function/exceptions/BusinessValidationException.java | Introduces a custom Java exception type with getters for multiple property shapes. |
| test/e2e/Apps/BasicJava/src/main/java/com/function/CustomExceptionPropertiesOrchestration.java | Adds a Java orchestrator/activity pair that throws the custom exception and returns FailureDetails. |
| src/WebJobs.Extensions.DurableTask/OutOfProcMiddleware.cs | Refines comments explaining why exception properties aren’t available in a non-JSON fallback parsing path. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+228
to
229
| [Trait("Java", "Skip")] // Java SDK v1.6.0 doesn't serialize custom exception properties | ||
| [Trait("DTS", "Skip")] // DTS doesn't support this feature yet. |
| [Trait("Python", "Skip")] // FailureDetails is a dotnet-isolated implementation detail | ||
| [Trait("Node", "Skip")] // FailureDetails is a dotnet-isolated implementation detail | ||
| [Trait("Java", "Skip")] // Include exception properties at Failure Details for Java is not supported yet. | ||
| [Trait("Java", "Skip")] // Java SDK v1.6.0 doesn't serialize custom exception properties |
Comment on lines
+33
to
+34
| // Should never reach here. | ||
| return null; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.