Closed — no review needed

[cheatsheet1999]

Closed. No action required.

[Copilot]

Pull request overview

This PR delivers three TLS 1.3 / GWv2 bug-bash follow-up fixes for the Azure IoT CLI extension, focused on preventing ambiguous DPS linked-hub states and ensuring generated connection strings / SAS tokens target the correct GWv2 endpoints.

Changes:

• Add a duplicate-link guard to az iot dps linked-hub create to prevent linking the same hub multiple times under different hostname types/auth methods.
• Reject --hostname-type service for device/module connection-string show commands and for device/module SAS token generation.
• Add --hostname-type {auto,classic,device,service} to az iot hub generate-sas-token and update SAS sr= audience construction to match the selected hostname type.

Reviewed changes

Copilot reviewed 11 out of 11 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
HISTORY.rst	Documents bug-bash follow-up fixes and the generate-sas-token behavior change.
azext_iot/operations/hub.py	Implements hostname-type selection for SAS audience and rejects unsupported service endpoint usage for device/module scopes.
azext_iot/core/custom.py	Adds _linked_hub_hostname helper and enforces DPS linked-hub duplicate protection across hostname types/auth modes.
azext_iot/_params.py	Wires --hostname-type parameter into iot hub generate-sas-token.
azext_iot/_help.py	Adds generate-sas-token examples demonstrating the new flag.
azext_iot/tests/iothub/core/test_iothub_utilities_unit.py	Adds unit tests covering hostname-type permutations and service rejection for CS show.
azext_iot/tests/iothub/core/test_iothub_utilities_int.py	Adds integration coverage for hub-scope SAS hostname-type permutations.
azext_iot/tests/iothub/devices/test_iothub_devices_int.py	Adds integration coverage for device-scope CS-show + SAS hostname-type permutations.
azext_iot/tests/iothub/modules/test_iothub_modules_int.py	Adds integration coverage for module-scope CS-show + SAS hostname-type permutations.
azext_iot/tests/dps/core/test_dps_linked_hub_unit.py	Adds unit coverage for duplicate-link guard and _linked_hub_hostname.
azext_iot/tests/dps/core/test_dps_linked_hub_int.py	Adds integration test ensuring cross-hostname-type duplicate linking is rejected.

Comments suppressed due to low confidence (1)

azext_iot/operations/hub.py:2273

• hostname_type is currently ignored when --connection-string is used (the code always calls _iot_build_sas_token_from_cs(...) without applying any hostname-type transformation). This makes az iot hub generate-sas-token --connection-string ... --hostname-type <...> behave the same for all hostname types and can confuse users now that the flag is advertised for this command. Consider either applying _transform_hostname(...) to the parsed HostName (and choosing device/service when hostname_type=auto based on scope), or explicitly rejecting --hostname-type when --connection-string is provided with a clear error message.

    if connection_string:
        return {
            DeviceAuthApiType.sas.value: _iot_build_sas_token_from_cs(
                connection_string,
                duration,
            ).generate_sas_token()
        }

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.