Allow ARM Auto-Signoff even when NotReadyForARMReview#43464
Open
tejaswiMinnu wants to merge 1 commit into
Open
Allow ARM Auto-Signoff even when NotReadyForARMReview#43464tejaswiMinnu wants to merge 1 commit into
tejaswiMinnu wants to merge 1 commit into
Conversation
tejaswiMinnu
requested review from
AkhilaIlla,
MSEvanhi,
benbp,
mikeharder and
raosuhas
as code owners
Next Steps to MergeNext steps that must be taken to merge this PR:
Comment generated by summarize-checks workflow run. |
mikeharder
reviewed
May 26, 2026
Comment on lines
+18
to
+21
| # Trigger after Summarize Checks to re-evaluate when NotReadyForARMReview is removed | ||
| # (label changes by workflows don't trigger pull_request_target events). | ||
| # See: https://github.com/Azure/azure-rest-api-specs/pull/42239 | ||
| "Summarize Checks", |
Member
There was a problem hiding this comment.
this creates a loop in the checks, which github will break after some length of chain (maybe 3 steps), but we shouldn't rely on it. you'll need to find another way.
"arm auto signoff status" -> "update labels" -> "summarize checks" -> "arm auto signoff status" -> ...
mikeharder
requested changes
May 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This issue has been ongoing, the ARM Auto signoff flow does not get triggered for incremental typespec changes.
Example PR - https://github.com/Azure/azure-rest-api-specs-pr/pull/27484
previous PR that dint work, so modifying the logic - #42239