[Refresh sdk-resourcemanager/kusto/armkusto]-generated-from-SDK Generation - Go-6325080#26822
Open
azure-sdk wants to merge 3 commits into
Open
[Refresh sdk-resourcemanager/kusto/armkusto]-generated-from-SDK Generation - Go-6325080#26822azure-sdk wants to merge 3 commits into
azure-sdk wants to merge 3 commits into
Conversation
….Kusto/Kusto/tspconfig.yaml', API Version: 2025-02-14, SDK Release Type: beta, and CommitSHA: 'b26c3c253cff26dd05361e882dbcf1b324f27dfd' in SpecRepo: 'https://github.com/Azure/azure-rest-api-specs' Pipeline run: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=6325080 Refer to https://eng.ms/docs/products/azure-developer-experience/develop/sdk-release/sdk-release-prerequisites to prepare for SDK release.
tadelesh
changed the title
Member
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refreshes the sdk/resourcemanager/kusto/armkusto management-plane SDK from azure-rest-api-specs for API version 2025-02-14, producing a v2.4.0-beta.1 release with updated generated clients, models, examples, and fakes.
Changes:
- Regenerates Kusto ARM clients/examples for
2025-02-14, including updated paging behavior (NextLink) and new polymorphic data-connection kinds. - Migrates generated artifacts/metadata to the newer Go code generator output (adds
tsp-location.yaml,testdata/_metadata.json, newversion.go, removes legacy AutoRest config files). - Updates fake servers to new paging and request dispatch patterns.
Reviewed changes
Copilot reviewed 42 out of 70 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| sdk/resourcemanager/kusto/armkusto/version.go | Adds generated module name/version constants for v2.4.0-beta.1. |
| sdk/resourcemanager/kusto/armkusto/tsp-location.yaml | Records the spec repo, commit, and directory used for generation. |
| sdk/resourcemanager/kusto/armkusto/testdata/_metadata.json | Captures API version and emitter version metadata for the generated output. |
| sdk/resourcemanager/kusto/armkusto/skus_client.go | Updates SKU listing pager to honor NextLink and switches to the 2025-02-14 api-version constant. |
| sdk/resourcemanager/kusto/armkusto/skus_client_example_test.go | Regenerates SKU pager example for the new API version and response shape. |
| sdk/resourcemanager/kusto/armkusto/scripts_client.go | Regenerates Scripts client (API version bump, paging, and request construction updates). |
| sdk/resourcemanager/kusto/armkusto/responses.go | Updates response wrapper types and comments; moves some serde helpers out. |
| sdk/resourcemanager/kusto/armkusto/responses_serde.go | Adds JSON marshal/unmarshal helpers for polymorphic response wrappers. |
| sdk/resourcemanager/kusto/armkusto/privatelinkresources_client.go | Regenerates PrivateLinkResources client with updated paging and api-version. |
| sdk/resourcemanager/kusto/armkusto/privatelinkresources_client_example_test.go | Regenerates PrivateLinkResources examples (Get + List pager). |
| sdk/resourcemanager/kusto/armkusto/privateendpointconnections_client.go | Regenerates PrivateEndpointConnections client with updated paging and api-version. |
| sdk/resourcemanager/kusto/armkusto/polymorphic_helpers.go | Extends polymorphic unmarshal to new managed-identity data connection kinds. |
| sdk/resourcemanager/kusto/armkusto/options.go | Regenerates option structs and improves LRO resume token comment wording. |
| sdk/resourcemanager/kusto/armkusto/operationsresultslocation_client.go | Regenerates OperationsResultsLocation client for 2025-02-14 (adds operationResultResponseType=Location). |
| sdk/resourcemanager/kusto/armkusto/operationsresultslocation_client_example_test.go | Regenerates example for OperationsResultsLocation.Get. |
| sdk/resourcemanager/kusto/armkusto/operationsresults_client.go | Regenerates OperationsResults client for 2025-02-14. |
| sdk/resourcemanager/kusto/armkusto/operationsresults_client_example_test.go | Regenerates example for OperationsResults.Get. |
| sdk/resourcemanager/kusto/armkusto/operations_client.go | Regenerates Operations client for 2025-02-14. |
| sdk/resourcemanager/kusto/armkusto/operations_client_example_test.go | Regenerates example for Operations list pager. |
| sdk/resourcemanager/kusto/armkusto/interfaces.go | Updates polymorphic interface documentation for new concrete types. |
| sdk/resourcemanager/kusto/armkusto/go.mod | Bumps dependency versions (notably sdk/azcore to v1.21.1 and golang.org/x/* indirects). |
| sdk/resourcemanager/kusto/armkusto/go.sum | Updates checksums for bumped dependencies. |
| sdk/resourcemanager/kusto/armkusto/CHANGELOG.md | Adds the 2.4.0-beta.1 release notes for the generated changes. |
| sdk/resourcemanager/kusto/armkusto/time_rfc3339.go | Removes legacy custom RFC3339 time parsing helpers from the old generator output. |
| sdk/resourcemanager/kusto/armkusto/fake/time_rfc3339.go | Removes legacy custom RFC3339 time parsing helpers from the fake package. |
| sdk/resourcemanager/kusto/armkusto/build.go | Removes legacy go:generate build script hook for the older generation flow. |
| sdk/resourcemanager/kusto/armkusto/autorest.md | Removes legacy AutoRest configuration file. |
| sdk/resourcemanager/kusto/armkusto/fake/internal.go | Refactors shared fake utilities (adds result type, fixes parseOptional return). |
| sdk/resourcemanager/kusto/armkusto/fake/server_factory.go | Updates fake server factory to use shared init helper and adds per-client field doc comments. |
| sdk/resourcemanager/kusto/armkusto/fake/skus_server.go | Updates fake SKU server transport for paging next-links injection and interceptor-enabled dispatch. |
| sdk/resourcemanager/kusto/armkusto/fake/scripts_server.go | Updates fake Scripts server transport for paging next-links injection and interceptor-enabled dispatch. |
| sdk/resourcemanager/kusto/armkusto/fake/sandboxcustomimages_server.go | Updates fake SandboxCustomImages server transport for paging next-links injection and interceptor-enabled dispatch. |
| sdk/resourcemanager/kusto/armkusto/fake/privatelinkresources_server.go | Updates fake PrivateLinkResources server transport for paging next-links injection and interceptor-enabled dispatch. |
| sdk/resourcemanager/kusto/armkusto/fake/privateendpointconnections_server.go | Updates fake PrivateEndpointConnections server transport for paging next-links injection and interceptor-enabled dispatch. |
| sdk/resourcemanager/kusto/armkusto/fake/operations_server.go | Updates fake Operations server transport for interceptor-enabled dispatch. |
| sdk/resourcemanager/kusto/armkusto/fake/operationsresults_server.go | Updates fake OperationsResults server transport for interceptor-enabled dispatch. |
| sdk/resourcemanager/kusto/armkusto/fake/operationsresultslocation_server.go | Updates fake OperationsResultsLocation server transport for interceptor-enabled dispatch (contains a path-matching bug; see comment). |
| sdk/resourcemanager/kusto/armkusto/fake/managedprivateendpoints_server.go | Updates fake ManagedPrivateEndpoints server transport for paging next-links injection and interceptor-enabled dispatch. |
| sdk/resourcemanager/kusto/armkusto/fake/dataconnections_server.go | Updates fake DataConnections server transport for paging next-links injection and interceptor-enabled dispatch. |
| sdk/resourcemanager/kusto/armkusto/fake/databaseprincipalassignments_server.go | Updates fake DatabasePrincipalAssignments server transport for paging next-links injection and interceptor-enabled dispatch. |
| sdk/resourcemanager/kusto/armkusto/fake/database_server.go | Updates fake Database server transport for interceptor-enabled dispatch. |
| sdk/resourcemanager/kusto/armkusto/fake/clusterprincipalassignments_server.go | Updates fake ClusterPrincipalAssignments server transport for paging next-links injection and interceptor-enabled dispatch. |
| sdk/resourcemanager/kusto/armkusto/fake/attacheddatabaseconfigurations_server.go | Updates fake AttachedDatabaseConfigurations server transport for paging next-links injection and interceptor-enabled dispatch. |
| sdk/resourcemanager/kusto/armkusto/fake/polymorphic_helpers.go | Extends fake polymorphic unmarshal to new managed-identity data connection kinds. |
| sdk/resourcemanager/kusto/armkusto/databaseprincipalassignments_client.go | Regenerates DatabasePrincipalAssignments client with updated paging and api-version. |
| sdk/resourcemanager/kusto/armkusto/database_client.go | Regenerates Database client (InviteFollower) with updated api-version and headers. |
| sdk/resourcemanager/kusto/armkusto/database_client_example_test.go | Regenerates Database.InviteFollower example for the new API version and response wrapper. |
| sdk/resourcemanager/kusto/armkusto/clusterprincipalassignments_client.go | Regenerates ClusterPrincipalAssignments client with updated paging and api-version. |
| sdk/resourcemanager/kusto/armkusto/client_factory.go | Updates ClientFactory header/comments to match new generator output. |
Files not reviewed (26)
- sdk/resourcemanager/kusto/armkusto/attacheddatabaseconfigurations_client.go: Language not supported
- sdk/resourcemanager/kusto/armkusto/attacheddatabaseconfigurations_client_example_test.go: Language not supported
- sdk/resourcemanager/kusto/armkusto/client_factory.go: Language not supported
- sdk/resourcemanager/kusto/armkusto/clusterprincipalassignments_client.go: Language not supported
- sdk/resourcemanager/kusto/armkusto/clusterprincipalassignments_client_example_test.go: Language not supported
- sdk/resourcemanager/kusto/armkusto/clusters_client.go: Language not supported
- sdk/resourcemanager/kusto/armkusto/constants.go: Language not supported
- sdk/resourcemanager/kusto/armkusto/database_client.go: Language not supported
- sdk/resourcemanager/kusto/armkusto/database_client_example_test.go: Language not supported
- sdk/resourcemanager/kusto/armkusto/databaseprincipalassignments_client.go: Language not supported
- sdk/resourcemanager/kusto/armkusto/databaseprincipalassignments_client_example_test.go: Language not supported
- sdk/resourcemanager/kusto/armkusto/databases_client.go: Language not supported
- sdk/resourcemanager/kusto/armkusto/databases_client_example_test.go: Language not supported
- sdk/resourcemanager/kusto/armkusto/dataconnections_client.go: Language not supported
- sdk/resourcemanager/kusto/armkusto/dataconnections_client_example_test.go: Language not supported
- sdk/resourcemanager/kusto/armkusto/fake/attacheddatabaseconfigurations_server.go: Language not supported
- sdk/resourcemanager/kusto/armkusto/fake/clusterprincipalassignments_server.go: Language not supported
- sdk/resourcemanager/kusto/armkusto/fake/clusters_server.go: Language not supported
- sdk/resourcemanager/kusto/armkusto/fake/database_server.go: Language not supported
- sdk/resourcemanager/kusto/armkusto/fake/databaseprincipalassignments_server.go: Language not supported
- sdk/resourcemanager/kusto/armkusto/fake/databases_server.go: Language not supported
- sdk/resourcemanager/kusto/armkusto/fake/dataconnections_server.go: Language not supported
- sdk/resourcemanager/kusto/armkusto/fake/internal.go: Language not supported
- sdk/resourcemanager/kusto/armkusto/fake/managedprivateendpoints_server.go: Language not supported
- sdk/resourcemanager/kusto/armkusto/fake/operations_server.go: Language not supported
- sdk/resourcemanager/kusto/armkusto/fake/operationsresults_server.go: Language not supported
Comment on lines
+84
to
88
| const regexStr = `/subscriptions/(?P<subscriptionId>[!#&$-;=?-\[\]_a-zA-Z0-9~%@]+)/providers/Microsoft\.Kusto/locations/(?P<location>[!#&$-;=?-\[\]_a-zA-Z0-9~%@]+)/operationResults/(?P<operationId>[!#&$-;=?-\[\]_a-zA-Z0-9~%@]+)?operationResultResponseType=Location` | ||
| regex := regexp.MustCompile(regexStr) | ||
| matches := regex.FindStringSubmatch(req.URL.EscapedPath()) | ||
| if matches == nil || len(matches) < 3 { | ||
| if len(matches) < 4 { | ||
| return nil, fmt.Errorf("failed to parse path %s", req.URL.Path) |
Member
|
@copilot revert this commit:45b0f50f6e8b361db211097b68e6062304096821 |
Agent-Logs-Url: https://github.com/Azure/azure-sdk-for-go/sessions/5fe64262-cd2e-4fd6-829e-82e17ec4d154 Co-authored-by: jliusan <6267860+jliusan@users.noreply.github.com>
Contributor
Done — I reverted commit |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Configurations: 'specification/azure-kusto/resource-manager/Microsoft.Kusto/Kusto/tspconfig.yaml', API Version: 2025-02-14, SDK Release Type: beta, and CommitSHA: 'b26c3c253cff26dd05361e882dbcf1b324f27dfd' in SpecRepo: 'https://github.com/Azure/azure-rest-api-specs' Pipeline run: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=6325080 Refer to https://eng.ms/docs/products/azure-developer-experience/develop/sdk-release/sdk-release-prerequisites to prepare for SDK release.