[AutoPR sdk-resourcemanager/monitor/armslis]-generated-from-SDK Generation - Go-6342624#26870
Draft
azure-sdk wants to merge 9 commits into
Draft
[AutoPR sdk-resourcemanager/monitor/armslis]-generated-from-SDK Generation - Go-6342624#26870azure-sdk wants to merge 9 commits into
azure-sdk wants to merge 9 commits into
Conversation
…rosoft.Monitor/Slis/tspconfig.yaml', API Version: 2025-03-01-preview, SDK Release Type: beta, and CommitSHA: '8be8c75d9bb11ea95d8a7e251db74aa78b5cd76c' in SpecRepo: 'https://github.com/Azure/azure-rest-api-specs' Pipeline run: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=6342624 Refer to https://eng.ms/docs/products/azure-developer-experience/develop/sdk-release/sdk-release-prerequisites to prepare for SDK release.
azure-sdk
requested review from
JiaqiZhang-Dev,
lirenhe and
tadelesh
as code owners
Contributor
|
Layered CRUD recording-based test scaffolding on top of the regen commit. Test file: |
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the sdk/resourcemanager/monitor/armslis management plane module generated from azure-rest-api-specs (Monitor SLIs, 2025-03-01-preview), bumping the package to v0.2.0 and incorporating the latest generator output.
Changes:
- Bumped module version to
v0.2.0and updatedtsp-location.yamlto the new spec commit. - Regenerated SDK code reflecting updated enum shapes/values and API-version handling.
- Added a
0.2.0changelog entry (needs to fully capture breaking enum value changes).
Reviewed changes
Copilot reviewed 6 out of 10 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| sdk/resourcemanager/monitor/armslis/version.go | Bumps module version constant to v0.2.0. |
| sdk/resourcemanager/monitor/armslis/tsp-location.yaml | Updates spec repo commit reference for generation provenance. |
| sdk/resourcemanager/monitor/armslis/testdata/_metadata.json | Updates the emitter version used to generate test assets. |
| sdk/resourcemanager/monitor/armslis/models.go | Updates generated model documentation for filter value encoding expectations. |
| sdk/resourcemanager/monitor/armslis/constants.go | Updates generated enums/constants (notably operator and sampling-related values) and adds a shared API-version constant. |
| sdk/resourcemanager/monitor/armslis/client.go | Uses the shared API-version constant and updated query encoding logic; adjusts placement of generated API version note. |
| sdk/resourcemanager/monitor/armslis/CHANGELOG.md | Adds 0.2.0 release notes (currently incomplete for breaking enum value changes). |
Files not reviewed (4)
- sdk/resourcemanager/monitor/armslis/client.go: Language not supported
- sdk/resourcemanager/monitor/armslis/constants.go: Language not supported
- sdk/resourcemanager/monitor/armslis/models.go: Language not supported
- sdk/resourcemanager/monitor/armslis/version.go: Language not supported
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
The test requires real Azure credentials, a managed identity, and an Azure Monitor Workspace populated with valid metrics. There are no recordings in azure-sdk-assets for this test, so it must be skipped unless AZURE_RECORD_MODE=live is set. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
tadelesh
approved these changes
May 23, 2026
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Add utils_test.go with TestMain to start the test-proxy, remove the skip-in-non-live-mode gate, switch defaults to sanitized values so the body matcher finds the recording in CI, and relax the response-name equality to allow the proxy-sanitized 'Sanitized' string. Recording asset tag updated in assets.json. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Member
|
@saleelpk Is this release PR ready? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Configurations: 'specification/monitoringservice/resource-manager/Microsoft.Monitor/Slis/tspconfig.yaml', API Version: 2025-03-01-preview, SDK Release Type: beta, and CommitSHA: '8be8c75d9bb11ea95d8a7e251db74aa78b5cd76c' in SpecRepo: 'https://github.com/Azure/azure-rest-api-specs' Pipeline run: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=6342624 Refer to https://eng.ms/docs/products/azure-developer-experience/develop/sdk-release/sdk-release-prerequisites to prepare for SDK release. Release plan link: https://azsdk-releaseplan-dashboard-hveph5aqhhcfhtgu.westus-01.azurewebsites.net/?releaseplan=2199 Submitted by: Saleel.Kattiyat@microsoft.com
Release Plan Details