Storage - Blob Stress Package Error Cleanup#49233
Draft
ibrandes wants to merge 7 commits into
Draft
Conversation
ibrandes
changed the title
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the Storage Blob stress test tooling to reduce error-prone behavior during retries/known-length uploads, align OpenTelemetry dependency versions, and improve stress environment setup (cert handling + storage endpoint generation).
Changes:
- Updated
CrcInputStreamto return a lazy snapshotMono<ContentInfo>instead of relying on EOF/sink signaling. - Adjusted OpenTelemetry runtime metrics registration (GC observers) and introduced
opentelemetry-bomdependency management in stress modules. - Updated stress infra scripts/templates: generate/import a PEM cert for the fault injector with a readiness wait-loop; improved Bicep outputs for cloud suffix + unique storage account names.
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| sdk/storage/azure-storage-stress/src/main/java/com/azure/storage/stress/TelemetryHelper.java | Updates GC runtime-metrics observer registration to the newer API signature. |
| sdk/storage/azure-storage-stress/src/main/java/com/azure/storage/stress/CrcInputStream.java | Replaces sink-based EOF signaling with lazy snapshot semantics for content info. |
| sdk/storage/azure-storage-stress/pom.xml | Imports opentelemetry-bom to align io.opentelemetry dependency versions. |
| sdk/storage/azure-storage-blob-stress/templates/stress-test-job.yaml | Switches fault injector cert generation/import to PEM and adds a wait loop before importing. |
| sdk/storage/azure-storage-blob-stress/stress-test-resources.bicep | Uses environment storage suffix and unique storage account naming to avoid collisions. |
| sdk/storage/azure-storage-blob-stress/scripts/stress-run.sh | Matches template behavior: waits for PEM cert then imports it into the JVM truststore. |
| sdk/storage/azure-storage-blob-stress/scripts/fault-injector.sh | Exports PEM cert instead of PFX to support keytool trust import. |
| sdk/storage/azure-storage-blob-stress/pom.xml | Imports opentelemetry-bom to align io.opentelemetry dependency versions. |
Comment on lines
+117
to
+119
| // duplicate() shares the underlying byte[] but gives the caller an independent | ||
| // position/limit so subsequent reads on this stream don't perturb the snapshot. | ||
| return new ContentInfo(crc.getValue(), length, head.duplicate()); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.