[AutoPR @azure-arm-security]-generated-from-SDK Generation - JS-6275780#38484
[AutoPR @azure-arm-security]-generated-from-SDK Generation - JS-6275780#38484azure-sdk wants to merge 8 commits into
Conversation
…curity/Security/tspconfig.yaml', API Version: 2026-04-01-preview, SDK Release Type: beta, and CommitSHA: '41784cfad64229e05cb37b1532a686a0cc3a60a9' in SpecRepo: 'https://github.com/Azure/azure-rest-api-specs' Pipeline run: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=6275780 Refer to https://eng.ms/docs/products/azure-developer-experience/develop/sdk-release/sdk-release-prerequisites to prepare for SDK release.
Next Steps to MergeOnly failed checks and required actions are listed below.
|
There was a problem hiding this comment.
Found 2 issues in this PR for @azure/arm-security@6.0.0-beta.7:
- Tool Issue (CHANGELOG.md): Changelog compares against
5.0.0(last stable) instead of6.0.0-beta.6(last published beta). This is likely a tooling bug. - Design Concern (API):
EventSourcetype exported from the SDK clashes with the well-known browserEventSourceWeb API, and the internalEventSource_2name indicates a naming collision in the spec. The type should be renamed using@clientNamein the spec repo.
📊 Structured Report
{"agent":"mgmt-reviewer","pr":38484,"summary":"issues_found","findings":[{"file":"sdk/security/arm-security/CHANGELOG.md","line":4,"issueType":"tool","category":"changelog-comparison-version","description":"CHANGELOG compares 6.0.0-beta.7 against 5.0.0 instead of the last published beta 6.0.0-beta.6"},{"file":"sdk/security/arm-security/review/arm-security-node.api.md","line":2098,"issueType":"design","category":"naming-collision","description":"EventSource type clashes with browser EventSource Web API; EventSource_2 _N suffix indicates naming collision in spec"}]}⚡ Benchmarked by Management Release Assistant
|
Note This analysis was generated by AI. Please review the classifications and root causes for accuracy. Breaking Change Analysis: @azure/arm-security 6.0.0-beta.7
API Versions by Sub-Service (old composite -> new single TypeSpec): The old SDK used
Spec References:
Total: 297 breaking changes -- Type 1: 9 | Type 2: 287 | Needs Review: 1 Type 1: API Version Upgrade -- 9 itemsAll 9 entries are in the
Type 2: TypeSpec / Emitter Migration -- 287 items
Items Requiring Review
Verification
Workflow phases completed: Phase 1 (context + API version map) -> Phase 2 (CHANGELOG extraction) -> Phase 3 (root cause + cascade detection for all 24 new-signature operations) -> Phase 4 (pattern matching) -> Phase 5 (self-review checklist) -> Phase 6 (counts verified, report built). Self-review checklist:
|
|
Azure/azure-rest-api-specs#43108 |
…curity/Security/tspconfig.yaml', API Version: 2026-04-01-preview, SDK Release Type: beta, and CommitSHA: 'ed1626873c0fd0d50df9538ed2608b4d7eac04f4' in SpecRepo: 'https://github.com/Azure/azure-rest-api-specs' Pipeline run: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=6312077 Refer to https://eng.ms/docs/products/azure-developer-experience/develop/sdk-release/sdk-release-prerequisites to prepare for SDK release.
|
@GalGoldi72 we find that operation group |
|
@kazrael2119 thanks for flagging this. We're currently tracking down the current owner of the Some context I've gathered so far:
Will post back here once I have a definitive answer from the feature owner. Apologies for the delay — this is blocking release plan #2226. |
|
@kazrael2119 — confirmed with the API owner: Additional verification I ran:
Please proceed with the PR — there's no consumer-facing breaking change since the API was never callable. Thanks for catching this and for your patience! |
|
Hi @GalGoldi72 we have two questions we'd like to confirm with you regarding the Security API spec: Question 1 –
|
|
@kazrael2119 — answers below: Q1 —
|
Now there's an issue in the sample generation with this model, we will bump a new version for our codegen to fix this and verify if this issue is fixed
For this one, |
|
@kazrael2119 — investigated further and confirmed empirically that the service actually accepts either Test results against
That said, the JIT Network Access feature isn't owned by our team and the original spec authors have moved on. We don't want to modify a contract we don't own without sign-off from the current owner, especially since the existing (buggy) contract has been in every published JS beta for years and there are no known consumer complaints. For unblocking this JS PR, please go ahead with your offered commit to add Thanks! |
…curity/Security/tspconfig.yaml', API Version: 2026-04-01-preview, SDK Release Type: beta, and CommitSHA: 'd0beff06ece5e53277d93233b70d46b703346576' in SpecRepo: 'https://github.com/Azure/azure-rest-api-specs' Pipeline run: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=6350492 Refer to https://eng.ms/docs/products/azure-developer-experience/develop/sdk-release/sdk-release-prerequisites to prepare for SDK release.
|
LGTM |
Configurations: 'specification/security/resource-manager/Microsoft.Security/Security/tspconfig.yaml', API Version: 2026-04-01-preview, SDK Release Type: beta, and CommitSHA: '41784cfad64229e05cb37b1532a686a0cc3a60a9' in SpecRepo: 'https://github.com/Azure/azure-rest-api-specs' Pipeline run: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=6275780 Refer to https://eng.ms/docs/products/azure-developer-experience/develop/sdk-release/sdk-release-prerequisites to prepare for SDK release. Release plan link: https://apps.powerapps.com/apps/821ab569-ae60-420d-8264-d7b5d5ef734c?release-plan-id=be88c343-344c-f111-bec7-6045bd05bddf Submitted by: ggoldshtein@microsoft.com
Release Plan Details
Spec pull request: [TSP Migration] security TypeSpec migrated from swagger azure-rest-api-specs#41888
Spec API version: 2026-04-01-preview