[AutoPR @azure-arm-databoundaries]-generated-from-SDK Generation - JS-6350130#38661
Open
azure-sdk wants to merge 2 commits into
Open
[AutoPR @azure-arm-databoundaries]-generated-from-SDK Generation - JS-6350130#38661azure-sdk wants to merge 2 commits into
azure-sdk wants to merge 2 commits into
Conversation
…esources/databoundaries/tspconfig.yaml', API Version: 2024-08-01, SDK Release Type: beta, and CommitSHA: '09f28748225dfa888ed244701dc762aaf13efb41' in SpecRepo: 'https://github.com/Azure/azure-rest-api-specs' Pipeline run: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=6350130 Refer to https://eng.ms/docs/products/azure-developer-experience/develop/sdk-release/sdk-release-prerequisites to prepare for SDK release.
github-actions
Bot
added
the
Mgmt
github-actions
Bot
added
mgmt-review-in-progress
Contributor
Next Steps to MergeOnly failed checks and required actions are listed below.
|
github-actions
Bot
added
mgmt-review-added
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
1 tool issue found in this PR.
The CHANGELOG.md incorrectly compares 1.0.0-beta.3 with 1.0.0-beta.1 instead of the actual last released version 1.0.0-beta.2, and the 1.0.0-beta.2 entry was also removed by the generation tool. This should be fixed before merging. The public API surface otherwise looks clean — no naming, type safety, or export concerns detected.
📊 Structured Report
{"agent":"mgmt-reviewer","pr":38661,"summary":"issues_found","findings":[{"file":"sdk/databoundaries/arm-databoundaries/CHANGELOG.md","line":4,"issueType":"tool","category":"changelog","description":"CHANGELOG compares 1.0.0-beta.3 with 1.0.0-beta.1 instead of 1.0.0-beta.2; beta.2 entry was also removed"}]}⚡ Benchmarked by Management Release Assistant
|
|
||
| ## 1.0.0-beta.3 (Unreleased) | ||
| ## 1.0.0-beta.3 (2026-05-26) | ||
| Compared with version 1.0.0-beta.1 |
Contributor
There was a problem hiding this comment.
🔴 Tool Issue — CHANGELOG.md:4
Compared with version 1.0.0-beta.1
The previous released version is 1.0.0-beta.2 (2025-08-22), not 1.0.0-beta.1. The generation tool incorrectly compared with beta.1 and also removed the beta.2 entry from the changelog.
Fix: Update CHANGELOG.md to compare with 1.0.0-beta.2 and restore the 1.0.0-beta.2 entry. Report this issue in the generation tool repository.
v-jiaodi
requested review from
a team,
JialinHuang803,
MaryGao,
jeremymeng,
qiaozha and
xirzec
as code owners
Contributor
There was a problem hiding this comment.
Pull request overview
This auto-generated PR updates the @azure/arm-databoundaries management package to the next-generation (RLC-style) client layout, adds a new operations operation group, and refreshes build/test/sample configuration in the sdk/databoundaries area.
Changes:
- Migrates the client implementation to an RLC-style
api/+classic/surface and updates the public API report accordingly. - Adds new static helpers (URL template + paging) and introduces
operations.list()as a new operation group. - Updates packaging/build configuration (warp/tsconfig/scripts) and refreshes samples and release metadata/changelog.
Reviewed changes
Copilot reviewed 65 out of 69 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
| sdk/databoundaries/ci.mgmt.yml | Minor whitespace/formatting updates in the CI pipeline definition. |
| sdk/databoundaries/arm-databoundaries/warp.config.yml | Defines explicit warp exports/targets for browser/esm/commonjs builds. |
| sdk/databoundaries/arm-databoundaries/vitest.config.ts | Removes leading blank line. |
| sdk/databoundaries/arm-databoundaries/tsp-location.yaml | Adds TypeSpec source location metadata. |
| sdk/databoundaries/arm-databoundaries/tsconfig.json | Updates TS project references (adds browser test config, reorders refs). |
| sdk/databoundaries/arm-databoundaries/test/snippets.spec.ts | Minor formatting change. |
| sdk/databoundaries/arm-databoundaries/src/static-helpers/urlTemplate.ts | Adds RFC6570 URL-template expansion helper. |
| sdk/databoundaries/arm-databoundaries/src/static-helpers/pagingHelpers.ts | Adds generic paging helper for PagedAsyncIterableIterator. |
| sdk/databoundaries/arm-databoundaries/src/static-helpers/cloudSettingHelpers.ts | Adds cloud-setting support for ARM endpoint selection. |
| sdk/databoundaries/arm-databoundaries/src/models/models.ts | Replaces old mapper-based models with serializer/deserializer model definitions. |
| sdk/databoundaries/arm-databoundaries/src/models/index.ts | Re-exports model types and Known* enums from models.ts. |
| sdk/databoundaries/arm-databoundaries/src/logger.ts | Adds package logger using @azure/logger. |
| sdk/databoundaries/arm-databoundaries/src/index.ts | Updates the package’s public exports and re-exports new helpers and types. |
| sdk/databoundaries/arm-databoundaries/src/databoundariesManegementClient.ts | Replaces ServiceClient-based client with wrapper over generated RLC context + classic ops. |
| sdk/databoundaries/arm-databoundaries/src/classic/** | Introduces classic operation group wrappers (dataBoundaries + operations). |
| sdk/databoundaries/arm-databoundaries/src/api/** | Adds generated RLC context + operation implementations and option types. |
| sdk/databoundaries/arm-databoundaries/samples/** | Updates/expands samples and sample package configs (adds operations list sample). |
| sdk/databoundaries/arm-databoundaries/samples-dev/** | Adds/updates source samples used for sample publishing. |
| sdk/databoundaries/arm-databoundaries/review/arm-databoundaries-node.api.md | Updates API report to reflect the new public API surface. |
| sdk/databoundaries/arm-databoundaries/README.md | Updates key links and fixes identity docs link. |
| sdk/databoundaries/arm-databoundaries/package.json | Updates exports/imports, dependencies, scripts, and published files list. |
| sdk/databoundaries/arm-databoundaries/metadata.json | Adds generation metadata and cross-language definition map. |
| sdk/databoundaries/arm-databoundaries/LICENSE | Minor formatting change. |
| sdk/databoundaries/arm-databoundaries/eslint.config.mjs | Minor formatting/structure change. |
| sdk/databoundaries/arm-databoundaries/config/tsconfig.* | Adds/updates browser test tsconfig and path mappings for tests. |
| sdk/databoundaries/arm-databoundaries/CHANGELOG.md | Rewrites the beta.3 entry and removes prior beta.2 entry. |
| sdk/databoundaries/arm-databoundaries/assets.json | Updates the assets tag reference. |
| sdk/databoundaries/arm-databoundaries/api-extractor.json | Formats json to single-line. |
| pnpm-lock.yaml | Updates lock entries for new deps/tools in this package. |
| .github/CODEOWNERS | Updates PR label metadata for this package path. |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
Comment on lines
+42
to
+44
| credentials: { | ||
| scopes: options.credentials?.scopes ?? ["https://management.azure.com/.default"], | ||
| }, |
Comment on lines
+104
to
+109
| "files": [ | ||
| "dist/", | ||
| "!dist/**/*.d.*ts.map", | ||
| "README.md", | ||
| "LICENSE" | ||
| ], |
Comment on lines
+3
to
5
| ## 1.0.0-beta.3 (2026-05-26) | ||
| Compared with version 1.0.0-beta.1 | ||
|
|
Comment on lines
+115
to
+120
| if (value === "") { | ||
| if (!ifEmpty) { | ||
| vals.push(ifEmpty); | ||
| } | ||
| return !vals.join("") ? undefined : `${first}${vals.join("")}`; | ||
| } |
Comment on lines
31
to
36
| "homepage": "https://github.com/Azure/azure-sdk-for-js/tree/main/sdk/databoundaries/arm-databoundaries", | ||
| "dependencies": { | ||
| "@azure/arm-databoundaries": "next", | ||
| "@azure/arm-databoundaries": "beta", | ||
| "dotenv": "latest", | ||
| "@azure/identity": "^4.2.1" | ||
| "@azure/identity": "^4.13.0" | ||
| }, |
Comment on lines
27
to
+32
| "homepage": "https://github.com/Azure/azure-sdk-for-js/tree/main/sdk/databoundaries/arm-databoundaries", | ||
| "dependencies": { | ||
| "@azure/arm-databoundaries": "next", | ||
| "@azure/arm-databoundaries": "beta", | ||
| "dotenv": "latest", | ||
| "@azure/identity": "^4.2.1" | ||
| "@azure/identity": "^4.13.0" | ||
| }, |
Comment on lines
+10
to
+19
| /** Interface representing a Operations operations. */ | ||
| export interface OperationsOperations { | ||
| /** List the operations for the provider */ | ||
| list: (options?: OperationsListOptionalParams) => PagedAsyncIterableIterator<Operation>; | ||
| } | ||
|
|
||
| function _getOperations(context: DataboundariesManegementContext) { | ||
| return { | ||
| list: (options?: OperationsListOptionalParams) => list(context, options), | ||
| }; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Configurations: 'specification/resources/resource-manager/Microsoft.Resources/databoundaries/tspconfig.yaml', API Version: 2024-08-01, SDK Release Type: beta, and CommitSHA: '09f28748225dfa888ed244701dc762aaf13efb41' in SpecRepo: 'https://github.com/Azure/azure-rest-api-specs' Pipeline run: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=6350130 Refer to https://eng.ms/docs/products/azure-developer-experience/develop/sdk-release/sdk-release-prerequisites to prepare for SDK release.