Skip to content

Resolve interface comments#38702

Open
EmmaZhu wants to merge 2 commits into
Azure:mainfrom
EmmaZhu:main
Open

Resolve interface comments#38702
EmmaZhu wants to merge 2 commits into
Azure:mainfrom
EmmaZhu:main

Conversation

@EmmaZhu
Copy link
Copy Markdown
Member

@EmmaZhu EmmaZhu commented May 27, 2026

Packages impacted by this PR

Issues associated with this PR

Describe the problem that is addressed by this PR

What are the possible designs available to address the problem? If there are more than one possible design, why was the one in this PR chosen?

Are there test cases added in this PR? (If not, why?)

Provide a list of related PRs (if any)

Command used to generate this PR:**(Applicable only to SDK release request PRs)

Checklists

  • Added impacted package name to the issue description
  • Does this PR needs any fixes in the SDK Generator?** (If so, create an Issue in the Autorest/typescript repository and link it here)
  • Added a changelog (if necessary)

Copilot AI review requested due to automatic review settings May 27, 2026 15:36
@github-actions github-actions Bot added the Storage Storage Service (Queues, Blobs, Files) label May 27, 2026
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the Storage Blob and Storage Data Lake client option type aliases to use client-specific *ClientOptions names, and updates constructor/from-connection-string signatures plus API reports accordingly (aimed at resolving interface/comment/review feedback around option type naming).

Changes:

  • Introduces client-specific *ClientOptions type aliases and wires them into the relevant client constructors.
  • Updates public API report files to reflect the renamed/added option types.
  • Exports the new Storage Blob option types from both Node and browser entrypoints.

Reviewed changes

Copilot reviewed 15 out of 15 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
sdk/storage/storage-file-datalake/src/models.ts Replaces the single DataLakeClientOptions alias with client-specific option type aliases.
sdk/storage/storage-file-datalake/src/DataLakeServiceClient.ts Updates DataLakeServiceClient ctor/fromConnectionString option types to DataLakeServiceClientOptions.
sdk/storage/storage-file-datalake/src/DataLakeFileSystemClient.ts Updates DataLakeFileSystemClient ctor option types to DataLakeFileSystemClientOptions.
sdk/storage/storage-file-datalake/src/clients.ts Updates DataLakePathClient/DataLakeFileClient ctor option types to client-specific aliases.
sdk/storage/storage-file-datalake/review/storage-file-datalake-react-native.api.diff.md API diff updates reflecting the new Data Lake option type names.
sdk/storage/storage-file-datalake/review/storage-file-datalake-node.api.md Removes DataLakeClientOptions from the API report and adds the new client-specific option types.
sdk/storage/storage-file-datalake/review/storage-file-datalake-browser.api.diff.md API diff updates reflecting the new Data Lake option type names.
sdk/storage/storage-blob/src/models.ts Adds Blob client-specific option type aliases (Append/Block/Page/Container/Service).
sdk/storage/storage-blob/src/index.ts Exports the new Blob option type aliases from the main entrypoint.
sdk/storage/storage-blob/src/index-browser.mts Exports the new Blob option type aliases from the browser entrypoint.
sdk/storage/storage-blob/src/ContainerClient.ts Updates ContainerClient ctor option type to ContainerClientOptions.
sdk/storage/storage-blob/src/Clients.ts Updates AppendBlobClient/BlockBlobClient/PageBlobClient ctor option types to client-specific aliases.
sdk/storage/storage-blob/src/BlobServiceClient.ts Updates BlobServiceClient ctor/fromConnectionString option types to BlobServiceClientOptions.
sdk/storage/storage-blob/review/storage-blob-node.api.md Updates the Blob API report to include the new option aliases and ctor signatures.
sdk/storage/storage-blob/review/storage-blob-browser.api.diff.md API diff updates reflecting the new Blob option type names.

Comment thread sdk/storage/storage-file-datalake/src/models.ts
Comment thread sdk/storage/storage-blob/src/models.ts
Comment thread sdk/storage/storage-blob/src/BlobServiceClient.ts Outdated
Copy link
Copy Markdown
Member

@maorleger maorleger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving the API changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Storage Storage Service (Queues, Blobs, Files)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants