update mgmt-review workflow to support auto-formatting and enhance safe outputs configuration#38716
Open
skywing918 wants to merge 8 commits into
Open
update mgmt-review workflow to support auto-formatting and enhance safe outputs configuration#38716skywing918 wants to merge 8 commits into
skywing918 wants to merge 8 commits into
Conversation
…ance safe outputs configuration
Contributor
There was a problem hiding this comment.
Pull request overview
Adds an auto-formatting workflow that the management-review agentic workflow can dispatch when it detects Check-format FAILED, replacing the previous "ask the contributor to run pnpm format" guidance with a label-triggered auto-fix.
Changes:
- New
format-auto-fix.ymlworkflow that resolves the target PR (viaworkflow_dispatchinput or by scanning open PRs forauto-format-needed), checks out the PR branch, runspnpm formaton changedsdk/packages, and pushes the fix. - Updated
mgmt-review.mdfrontmatter to allowdispatch-workflow: [format-auto-fix]and raiseadd-labels.maxfrom 1 to 2, plus new Step 3 / template / mapping changes that direct the agent to label + dispatch instead of asking the contributor to format locally. - Regenerated
mgmt-review.lock.ymlto exposedispatch_workflow,add_labels(max:2), dynamicformat_auto_fixtool, and addactions: writeto theconclusionandsafe_outputsjobs.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 7 comments.
| File | Description |
|---|---|
| .github/workflows/format-auto-fix.yml | New workflow that finds the target PR, runs pnpm format on affected sdk packages, commits/pushes, and posts a result comment. |
| .github/workflows/mgmt-review.md | Adds dispatch-workflow safe output, bumps add-labels.max to 2, and rewrites Check-format guidance / Step 3 / output template to use the label + dispatch flow. |
| .github/workflows/mgmt-review.lock.yml | Compiled output reflecting the new safe outputs (dispatch tool, add_labels(max:2), actions: write on conclusion and safe_outputs jobs). |
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
jeremymeng
reviewed
May 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #38663
This pull request introduces a new workflow for automated formatting fixes on SDK packages and integrates it into the management review system. The changes enable the review workflow to trigger the new formatting workflow as an auto-fix step, improving automation and developer experience. The most important changes are grouped below:
New Workflow for Automated Formatting Fixes:
.github/workflows/format-auto-fix.yml, a workflow that can be manually triggered to runpnpm formaton only the affected SDK packages in a pull request, committing and pushing any needed formatting changes.Integration with Management Review Workflow:
.github/workflows/mgmt-review.lock.ymlto:dispatch_workflowtool (specifically for theformat-auto-fixworkflow) to the list of safe output tools, including its configuration, permissions, and dynamic tool schema. [1] [2] [3] [4] [5] [6]Safe Outputs and Documentation Updates:
.github/workflows/mgmt-review.mdto declaredispatch-workflowas a safe output tool (forformat-auto-fix) and clarified that the failure list is used for both auto-fix attempts and the final PR comment. [1] [2]Metadata Updates:
.github/workflows/mgmt-review.lock.ymlto reflect the new tool and workflow integration.These changes collectively enable the management review workflow to automatically trigger formatting fixes on PRs, streamlining the review and merge process.

SDK Format Auto-Fix
https://github.com/skywing918/azure-sdk-for-js/actions/runs/26567029742
Test PR
skywing918#21