Peel Azure.AI.Extensions.OpenAI off the NoWarn skip-list#59685
Merged
Conversation
- Remove from eng/NoWarnSkipValidation.txt. - Drop the project-wide <NoWarn> block from src/Azure.AI.Extensions.OpenAI.csproj (was CS1591, OPENAI001, AZC0035, AAIP001). - Add eng/analyzerallowlist/Azure.AI.Extensions.OpenAI.txt covering OPENAI001 (external experimental opt-in; the library is by design a wrapper of the preview OpenAI surface) and AZC0035 (the analyzer fires on ResponseResult and StreamingResponseUpdate, both declared in the external OpenAI SDK; the analyzer is missing an assembly check in ExtractOutputModelFromReturnType and a fix will be filed upstream — remove this entry once it flows in). - Drop stale CS1591 and AAIP001 entries from the csproj (neither fires). - Add XML doc comments to 90 hand-written public members across 21 Custom/ files so CS1591 no longer needs a project-wide suppression. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…35 from Azure.AI.Extensions.OpenAI The new analyzer package includes the AZC0035 external-types fix (Azure#59647). With that fix in place, AZC0035 no longer fires on ResponseResult / StreamingResponseUpdate (declared in the external OpenAI SDK), so the suppression can be removed from Azure.AI.Extensions.OpenAI's allow-list. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
m-nash
requested review from
a team,
benbp,
dargilco,
glharper,
hallipr,
jsquire,
nick863,
trangevi,
trrwilson and
weshaggard
as code owners
JoshLove-msft
approved these changes
Jun 4, 2026
jsquire
approved these changes
Jun 4, 2026
Copilot stopped reviewing on behalf of
m-nash due to an error
June 4, 2026 19:11
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Peels
Azure.AI.Extensions.OpenAIoff theeng/NoWarnSkipValidation.txtskip-list as part of the ongoing NoWarn-visibility migration.What's in this PR
Peel-off (first commit):
eng/NoWarnSkipValidation.txt.<NoWarn>block fromsrc/Azure.AI.Extensions.OpenAI.csproj(wasCS1591;OPENAI001;AZC0035;AAIP001).eng/analyzerallowlist/Azure.AI.Extensions.OpenAI.txtcoveringOPENAI001(this library is by design a wrapper of the preview OpenAI surface, so the experimental opt-in is acknowledged once at the assembly level).CS1591andAAIP001entries from the csproj (neither fires).Custom/files soCS1591no longer needs a project-wide suppression.Analyzer version bump (second commit):
Azure.ClientSdk.Analyzers0.1.1-dev.20260129.1→0.1.1-dev.20260604.1ineng/centralpackagemanagement/Directory.Packages.props. The new package picks up the AZC0035 external-types fix from Migrate ModelFactoryAnalyzer (AZC0035) into azure-sdk-for-net and fix external-type false positive #59647.AZC0035no longer fires onResponseResult/StreamingResponseUpdate(both declared in the external OpenAI SDK), so noAZC0035suppression is needed for this project.Validation
dotnet build src/Azure.AI.Extensions.OpenAI.csproj→ Build succeeded, 0 warnings, 0 errors across net8.0 / net10.0 / netstandard2.0.Related
ModelFactoryAnalyzerintosdk/tools/Azure.SdkAnalyzersand fixed the AZC0035 external-types false-positive (merged).azure-sdk-tools(merged).