-
Notifications
You must be signed in to change notification settings - Fork 238
typespec authoring agentic search improvements #15841
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -9,6 +9,15 @@ | |
|
|
||
| 1. **Select URLs** — read [reference-document-links.md](reference-document-links.md). Select only the URLs relevant to the user's request and Step 1 result. If unsure, select all. | ||
| 2. **Fetch** — `web_fetch` each selected URL. Extract content as markdown. | ||
| - **Timeout**: Allow at most 30 seconds per URL fetch. If a fetch times out or fails, skip it and continue with the remaining URLs. | ||
| - **Total budget**: Complete all fetching within 2 minutes. If the budget is exceeded, stop fetching and proceed with whatever content has been collected. | ||
| 3. **Search** — find content matching a query derived from the user's request and Step 1 result. Choose the most effective local search tool available. | ||
| 4. **Iterate** — if initial results are insufficient, refine the query or fetch additional pages/URLs until the information satisfies the query. | ||
| 4. **Iterate** — if initial results are insufficient, refine the query or fetch additional pages/URLs until the information satisfies the query. Respect the total time budget. | ||
| 5. **Return** — provide the extracted guidance to the caller. | ||
|
|
||
| ## Fallback | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. could we put the fallback part to thttps://github.com/Azure/azure-sdk-tools/blob/main/.github/skills/azure-typespec-author/references/authoring-plan.md?
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I saw there is a fall back added here: https://github.com/Azure/azure-sdk-tools/pull/15840/changes#diff-ca1df672aae30ef5d37ee71419674b77f4813b1169025e86a4c2b50baf1e3f16R16 |
||
|
|
||
| If all URL fetches fail or the total budget expires with no useful content: | ||
| - Proceed without agentic search results. | ||
| - Rely on the MCP tool (`azsdk_typespec_generate_authoring_plan`) and built-in knowledge. | ||
| - Do NOT block the workflow waiting for unreachable URLs. | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just curious on the cases that timeout happen? Because from my previous perf test, web_fetch avg time is 0.55s. And I did not encounter timeout case before.
#14740 (comment)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm fine with holding off on this pr until we have more data/feedback. This came up when I was working on the evals with copilot and it was analyzing how long it took to process a request, however I wouldnt say there's enough data to strongly push to get this into the skill right now.