Skip to content

Onboard azure-sphere-tools pipelines to Network Isolation policy#29

Merged
glcardoz merged 15 commits into
mainfrom
copilot/onboard-azure-sphere-tools
Jun 2, 2026
Merged

Onboard azure-sphere-tools pipelines to Network Isolation policy#29
glcardoz merged 15 commits into
mainfrom
copilot/onboard-azure-sphere-tools

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented May 14, 2026

Context

This PR onboards the azure-sphere-tools pipeline to the Network Isolation policy (SFI ES4.2.4) and fixes flaky ClearErrorReportData tests.

This is part of a two-PR change to onboard azure-sphere-tools to network isolation:

  1. SdkBuildScripts PR — must be completed first
  2. This PR (azure-sphere-tools) — complete after SdkBuildScripts merges, then revert the temporary ref: changes below

Changes in this PR

Network Isolation

  • build.yml: Added networkisolation feature flag with Permissive,CFSClean,CFSClean2,CFSClean3 policy to the non-official OneBranch template.
  • build-release.yml: Added the same networkisolation feature flag to the official OneBranch template.
  • build.yml: Temporary ref: changes to point SdkBuildScripts and azure-sphere-tools resources at feature branches (marked with # TODO comments — revert to refs/heads/main after both PRs merge).

Test Fixes

  • ClearErrorReportDataTests.cs: Fixed Assert.AreEqual argument order (expected, actual were swapped). Increased poll timeout from 1s to 5s. Added retry logic (up to 3 attempts) to handle intermittent device delays when clearing error report data.
  • test_clear_error_report_data.py: Same fixes — increased timeout from 1s to 5s and added retry logic (up to 3 attempts).

Validation

  • Automated on-device testing (both .NET and Python tests pass)

Copilot AI linked an issue May 14, 2026 that may be closed by this pull request
Copilot AI changed the title [WIP] Onboard azure-sphere-tools pipeline to network isolation policy Onboard azure-sphere-tools pipelines to Network Isolation policy May 14, 2026
Copilot AI requested a review from glcardoz May 14, 2026 10:58
@glcardoz glcardoz marked this pull request as ready for review May 14, 2026 11:00
@glcardoz
Copy link
Copy Markdown
Contributor

@copilot also onboard to CFSClean3

Copy link
Copy Markdown
Contributor Author

Copilot AI commented May 26, 2026

@copilot also onboard to CFSClean3

Done — updated both build.yml and build-release.yml to include CFSClean3 in the policy (commit d30f624).

Comment thread .azuredevops/build.yml Outdated
Comment thread .azuredevops/build.yml Outdated
@glcardoz glcardoz merged commit 670fbe7 into main Jun 2, 2026
5 checks passed
@glcardoz glcardoz deleted the copilot/onboard-azure-sphere-tools branch June 2, 2026 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Network Isolation Policy

3 participants