Adding PutBlobFromUrl for AzCopy#1378
Closed
siminsavani-msft wants to merge 78 commits into
Closed
Conversation
Contributor
siminsavani-msft
commented
Mar 25, 2021
siminsavani-msft
commented
- Refactoring AzCopy to use PutBlobFromUrl
AzCopy v10.9.0 Release
mohsha-msft
suggested changes
Mar 27, 2021
|
|
||
| if err != nil { | ||
| c.jptm.FailActiveSend("Copy Blob from URL", err) | ||
| c.jptm.FailActiveSend("Put Blob from URL", err) |
Contributor
There was a problem hiding this comment.
Couple of things :-
- There is a syntax error in testsuite folder (smoke tests). Please run
go build ./testSuiteto detect and fix that. - I see the default service version of AzCopy is
2019-12-12.PutBlobFromUrl()works with2020-04-08. Let's review and merge this PR to update the service of file SDK to2020-04-08. After this PR is merged, we can raise default service version of AzCopy from2019-12-12to2020-04-08
siminsavani-msft
requested review from
adreed-msft,
nakulkar-msft and
zezha-msft
mohsha-msft
approved these changes
Apr 7, 2021
Contributor
mohsha-msft
left a comment
mohsha-msft
left a comment
There was a problem hiding this comment.
LGTM. There are conflicts and breaking test cases. We can merge once we do the needful.
zezha-msft
approved these changes
Apr 8, 2021
nakulkar-msft
approved these changes
Apr 9, 2021
Contributor
|
Rebase is needed to fix the CI. |
…ure/azure-storage-azcopy into siminsavani/AddPutBlobFromUrl
mohsha-msft
suggested changes
Apr 9, 2021
…ure/azure-storage-azcopy into siminsavani/AddPutBlobFromUrl
…ure/azure-storage-azcopy into siminsavani/AddPutBlobFromUrl
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.