test pyspec#3453
Open
wonwuakpa-msft wants to merge 8 commits into
Open
Conversation
Member
Author
|
\azp run |
wonwuakpa-msft
requested review from
adreed-msft,
dphulkar-msft,
gapra-msft,
seanmcc-msft,
shnayak-msft,
souravgupta-msft and
tanyasethi-msft
as code owners
Contributor
There was a problem hiding this comment.
Pull request overview
Updates AzCopy’s ADLS Gen2 ACL handling to correctly target the filesystem root when the transfer path is empty, alongside dependency and CI adjustments.
Changes:
- Handle empty source/destination paths by using the filesystem root directory client (
NewDirectoryClient("/")) for ACL get/set. - Update Go dependencies (notably Azure SDK packages) in
go.mod/go.sum. - Adjust E2E pipeline Azurite startup to include
--skipApiVersionCheck.
Reviewed changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
ste/sourceInfoProvider-Blob.go |
Adds root-directory ACL retrieval when SrcFilePath is empty; improves error context. |
ste/sender-blobFolders.go |
Adds root-directory ACL setting when DstFilePath is empty. |
go.mod |
Updates Azure SDK + x/* dependencies (including azblob version change). |
go.sum |
Syncs module checksums to match go.mod updates. |
AzuriteConfig |
Adds a new JSON file (appears to be a local artifact). |
azurePipelineTemplates/run-e2e.yml |
Adds --skipApiVersionCheck to Azurite invocation in CI. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+151
to
+153
| if err != nil { | ||
| return nil, fmt.Errorf("Error getting root directory ACL: %v", err) | ||
| } |
Comment on lines
+159
to
+161
| if err != nil { | ||
| return nil, fmt.Errorf("Error getting file ACL: %v", err) | ||
| } |
Comment on lines
+75
to
+80
| // We cannot set ACLs with an empty file path | ||
| // https://learn.microsoft.com/en-us/azure/storage/blobs/data-lake-storage-access-control#can-i-set-the-acl-of-a-container | ||
| dstDirectoryDatalakeClient := fileSystemClient.NewDirectoryClient("/") | ||
| _, err = dstDirectoryDatalakeClient.SetAccessControl(b.jptm.Context(), &file.SetAccessControlOptions{ACL: acl}) | ||
| if err != nil { | ||
| b.jptm.FailActiveSend("Setting Root Directory ACL", err) |
Comment on lines
+149
to
+154
| if b.jptm.Info().DstFilePath == "" { | ||
| dstDirectoryDatalakeClient := dstFileSystemClient.NewDirectoryClient("/") | ||
| _, err = dstDirectoryDatalakeClient.SetAccessControl(b.jptm.Context(), &file.SetAccessControlOptions{ACL: acl}) | ||
| if err != nil { | ||
| b.jptm.FailActiveSend("Setting Root Directory ACL", err) | ||
| return folderPropertiesSetInCreation{} // standard completion will detect failure |
| @@ -0,0 +1 @@ | |||
| {"instaceID":"565d2ba6-9736-4429-b396-41298b2f305a"} No newline at end of file | |||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Feature / Bug Fix: (Brief description of the feature or issue being addressed)
Related Links:
Issues
Team thread
Documents
[Email Subject]
Type of Change
How Has This Been Tested?
Thank you for your contribution to AzCopy!