default Slurm Accounting SSL certificate to be combined certs required for Azure MySQL Database by azreenz · Pull Request #504 · Azure/cyclecloud-slurm

azreenz · 2026-04-28T16:49:11Z

Always install three SSL certificatetes and combine them to AzureCA{version}.pem as advised by Azure during root certificate rotation. https://learn.microsoft.com/en-us/azure/mysql/flexible-server/security-tls-root-certificate-rotation#steps
Additionally, install optional custom SSL cert slurm.accounting.certificate specified by user in template

The three certificates installed are

Copilot

Pull request overview

Updates Slurm accounting SSL certificate handling so that the default option installs a combined CA bundle (per Azure MySQL TLS root rotation guidance) and writes it to AzureCA.pem for SlurmDBD to use.

Changes:

Add a “Combined Certs” option (and make it the default) for the accounting certificate URL in the cluster template.
Implement installer logic to download three CA certs, convert/assemble them, and write the combined PEM to ${config_dir}/AzureCA.pem.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.

File	Description
templates/slurm.txt	Adds “Combined Certs” entry and sets it as the default value for the accounting SSL certificate parameter.
azure-slurm-install/install.py	Adds `_install_combined_certs()` and wires it into accounting setup when the “Combined Certs” option is selected.

Copilot

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.

Copilot

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.

Copilot

Pull request overview

Copilot reviewed 5 out of 6 changed files in this pull request and generated 3 comments.

Copilot

Pull request overview

Copilot reviewed 5 out of 6 changed files in this pull request and generated 3 comments.

aditigaur4 · 2026-04-30T23:28:07Z

-        Config.Entries := {[Value=""], [Value="AzureCA.pem"]}
-        DefaultValue = ""
+        Config.Entries := {[Value=""], [Value="AzureCA_bundle.pem"]}
+        DefaultValue = "AzureCA_bundle.pem"


I understand this was done before-- but this is weird. This is saying "Either its a URL or its a string that actually points to a file we know about"...

IMO just remove the default value.

okay so when this value is empty we should always point StorageParameters=SSL_CA=/etc/slurm/AzureCA_bundle.pem? Right now in the code if you leave acct_cert_url empty then we comment out StorageParameters in slurmdbd.conf

azreenz · 2026-05-01T14:49:28Z

New Template looks like this

And when custom ssl is enabled both certs are avail in /etc/slurm but slurmdbd.conf points to CustomCA.pem

root@azdbd-u22-custom-scheduler:/etc/slurm# ls
AzureCA_4.0.8.pem  azure.conf   gres.conf                        plugstack.conf    site_specific.conf  topology.conf
CustomCA.pem       cgroup.conf  job_submit.lua.azurehpc.example  plugstack.conf.d  slurm.conf
accounting.conf    epilog.d     keep_alive.conf                  prolog.d          slurmdbd.conf

StorageParameters=SSL_CA=/etc/slurm/CustomCA.pem

Copilot

Pull request overview

Copilot reviewed 5 out of 6 changed files in this pull request and generated 5 comments.

…d for Azure MySQL Database - Package bundled cert during build time - Always install and link bundled cert - Point slurmdbd.conf to AzureCA_{version}.pem when no custom ssl cert is specified - install and link custom cert in addition to bundled cert when specified in template and point slurmdbd.conf to CustomCA.pem

Copilot

Pull request overview

Copilot reviewed 5 out of 6 changed files in this pull request and generated no new comments.

Copilot AI review requested due to automatic review settings April 28, 2026 16:49

Copilot started reviewing on behalf of azreenz April 28, 2026 16:49 View session

Copilot AI reviewed Apr 28, 2026

View reviewed changes

Comment thread templates/slurm.txt Outdated

Comment thread templates/slurm.txt Outdated

Comment thread azure-slurm-install/install.py Outdated

Comment thread azure-slurm-install/install.py Outdated

azreenz added the Do-not-merge Do not merge yet label Apr 29, 2026

azreenz force-pushed the azreenzaman/combined-certs branch from 1a94460 to 94cb695 Compare April 29, 2026 20:44

azreenz requested a review from Copilot April 29, 2026 20:44

Copilot started reviewing on behalf of azreenz April 29, 2026 20:45 View session

Copilot AI reviewed Apr 29, 2026

View reviewed changes

Comment thread templates/slurm.txt Outdated

azreenz removed the Do-not-merge Do not merge yet label Apr 29, 2026

bwatrous reviewed Apr 29, 2026

View reviewed changes

Comment thread azure-slurm-install/install.py Outdated

bwatrous reviewed Apr 29, 2026

View reviewed changes

Comment thread azure-slurm-install/install.py Outdated

azreenz force-pushed the azreenzaman/combined-certs branch from f9cb7e0 to 4e7a565 Compare April 30, 2026 14:34

azreenz requested a review from Copilot April 30, 2026 15:15

Copilot started reviewing on behalf of azreenz April 30, 2026 15:16 View session

Copilot AI reviewed Apr 30, 2026

View reviewed changes

Comment thread azure-slurm-install/package.py

Comment thread azure-slurm-install/package.py

Comment thread azure-slurm-install/package.py Outdated

azreenz force-pushed the azreenzaman/combined-certs branch from 4e7a565 to 4b5616f Compare April 30, 2026 15:34

aditigaur4 reviewed Apr 30, 2026

View reviewed changes

Comment thread azure-slurm-install/install.py Outdated

azreenz force-pushed the azreenzaman/combined-certs branch 2 times, most recently from 0ae4a1a to a8443d8 Compare April 30, 2026 17:21

bwatrous reviewed Apr 30, 2026

View reviewed changes

Comment thread azure-slurm-install/install.py Outdated

azreenz requested a review from Copilot April 30, 2026 19:50

Copilot AI reviewed Apr 30, 2026

View reviewed changes

Comment thread azure-slurm-install/install.py Outdated

Comment thread azure-slurm-install/install.py Outdated

Comment thread README.md Outdated

Copilot started reviewing on behalf of azreenz April 30, 2026 20:02 View session

azreenz force-pushed the azreenzaman/combined-certs branch from 995efe9 to 8aaefd0 Compare April 30, 2026 20:49

azreenz requested a review from Copilot April 30, 2026 20:49

Copilot started reviewing on behalf of azreenz April 30, 2026 20:50 View session

Copilot AI reviewed Apr 30, 2026

View reviewed changes

Comment thread azure-slurm-install/install.py Outdated

Comment thread azure-slurm-install/install.py Outdated

Comment thread templates/slurm.txt Outdated

azreenz force-pushed the azreenzaman/combined-certs branch from 13259cb to 0892a4f Compare April 30, 2026 21:22

bwatrous previously approved these changes Apr 30, 2026

View reviewed changes

aditigaur4 reviewed Apr 30, 2026

View reviewed changes

Comment thread azure-slurm-install/install.py

aditigaur4 reviewed Apr 30, 2026

View reviewed changes

azreenz dismissed bwatrous’s stale review via d43687f May 1, 2026 14:43

azreenz requested a review from Copilot May 1, 2026 14:46

Copilot started reviewing on behalf of azreenz May 1, 2026 14:46 View session

Copilot AI reviewed May 1, 2026

View reviewed changes

Comment thread azure-slurm-install/package.py

Comment thread azure-slurm-install/install.py

Comment thread azure-slurm-install/install.py Outdated

Comment thread templates/slurm.txt

Comment thread azure-slurm-install/install.py Outdated

azreenz force-pushed the azreenzaman/combined-certs branch from d43687f to 06a396a Compare May 1, 2026 15:06

azreenz changed the title ~~default Slurm Accounting SSL certificate fetch to install combined certs~~ default Slurm Accounting SSL certificate to be combined certs required for Azure MySQL Database May 1, 2026

azreenz force-pushed the azreenzaman/combined-certs branch from 06a396a to 597b303 Compare May 1, 2026 15:11

azreenz force-pushed the azreenzaman/combined-certs branch from 597b303 to 1fa5d23 Compare May 1, 2026 15:37

azreenz requested a review from Copilot May 1, 2026 15:39

Copilot started reviewing on behalf of azreenz May 1, 2026 15:40 View session

aditigaur4 approved these changes May 1, 2026

View reviewed changes

Copilot AI reviewed May 1, 2026

View reviewed changes

bwatrous reviewed May 1, 2026

View reviewed changes

Comment thread azure-slurm-install/install.py

bwatrous reviewed May 1, 2026

View reviewed changes

Comment thread azure-slurm-install/package.py

bwatrous approved these changes May 1, 2026

View reviewed changes

aditigaur4 merged commit 3e1de5b into master May 1, 2026
7 checks passed

Conversation

azreenz commented Apr 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

aditigaur4 Apr 30, 2026

Choose a reason for hiding this comment

Uh oh!

azreenz Apr 30, 2026

Choose a reason for hiding this comment

Uh oh!

azreenz commented May 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

azreenz commented Apr 28, 2026 •

edited

Loading

azreenz commented May 1, 2026 •

edited

Loading