update readme for slurm accounting changes#507
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the Slurm job accounting documentation in README.md to reflect the shift from supplying an SSL certificate URL to supplying a custom SSL certificate (CA bundle) content, aligning the README with the current template/UI behavior for accounting SSL configuration.
Changes:
- Replace “SSL Certificate URL” guidance with “Custom SSL Certificate” guidance.
- Document the default CA certificates used for Azure Database for MySQL Flex Server.
| Criterion | Max Points | Points Awarded | Notes |
|---|---|---|---|
| PR Description Accuracy (20) | 20 | 0 | PR description not provided (only a title was included). |
| PR Atomicity (20) | 20 | 20 | Single, focused documentation update. |
| Logical Implementation (10) | 10 | 10 | N/A (documentation-only) and straightforward. |
| Regression Risk (10) | 10 | 10 | No runtime/code behavior changes. |
| Exception Handling (10) | 10 | 10 | N/A (documentation-only). |
| Code Comments (10) | 10 | 10 | N/A (documentation-only). |
| Repetitive Code (10) | 10 | 10 | N/A. |
| Spelling (5) | 5 | 5 | No spelling issues identified in the changed lines. |
| Logging Quality (5) | 5 | 5 | N/A (documentation-only). |
FINAL SCORE: 80/100
RECOMMENDATION: MERGE WITH FOLLOW-UPS
RATIONALE: Documentation is close to correct, but the current wording risks confusing users about whether they should paste URLs vs PEM contents (and one listed cert is DER-format). Address the noted doc clarification before merge; no code risk otherwise.
BLOCKERS:
- Clarify in README that the field expects PEM contents (CA bundle), not URLs, and that the default Azure MySQL CA bundle is already provided unless the user overrides it.
831c807 to
59ba0f3
Compare
dd65e98 to
c83dfc0
Compare
c83dfc0 to
5bd5ebb
Compare
bwatrous
approved these changes
May 8, 2026
ryanhamel
approved these changes
May 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update slurm accounting section in read me to account for new SSL certificate changes