Add note to dashboards that certain panels require accounting#508
Merged
Conversation
…nabled to populate
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the Grafana dashboards shipped with azure-slurm-exporter to clarify that certain panels will not populate unless Slurm accounting is enabled, helping users quickly diagnose “empty dashboard” scenarios.
Changes:
- Added a markdown “accounting required” note panel to the Failed Jobs dashboard.
- Added a markdown “accounting required” note panel beneath the Finished Jobs panel in the main azslurm dashboard.
Scorecard
| Criterion | Max Points | Points Awarded | Notes |
|---|---|---|---|
| PR Description Accuracy | 20 | 20 | Matches the dashboard note additions. |
| PR Atomicity | 20 | 20 | Single-purpose change (dashboard messaging). |
| Logical Implementation | 10 | 10 | Straightforward dashboard JSON additions. |
| Regression Risk | 10 | 10 | Low risk; informational panels only. |
| Exception Handling | 10 | 10 | N/A for static dashboard JSON. |
| Code Comments | 10 | 10 | N/A for static dashboard JSON. |
| Repetitive Code | 10 | 10 | No meaningful duplication introduced. |
| Spelling | 5 | 0 | Minor grammar/capitalization in new note text. |
| Logging Quality | 5 | 5 | N/A for static dashboard JSON. |
FINAL SCORE: 95/100
RECOMMENDATION: MERGE
RATIONALE: Informational-only dashboard changes with low operational risk; minor wording tweaks are optional follow-up items.
BLOCKERS: None
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| azure-slurm-exporter/dashboards/failed-jobs.json | Adds a text panel note indicating Slurm accounting is required for the dashboard to populate. |
| azure-slurm-exporter/dashboards/azslurm.json | Adds a text panel note under the Finished Jobs panel indicating Slurm accounting is required. |
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
bwatrous
approved these changes
May 8, 2026
ryanhamel
approved these changes
May 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add note under certain panels that require accounting to be enabled

