Skip to content

Add note to dashboards that certain panels require accounting#508

Merged
azreenz merged 3 commits into
masterfrom
azreenzaman/dashboard-changes
May 11, 2026
Merged

Add note to dashboards that certain panels require accounting#508
azreenz merged 3 commits into
masterfrom
azreenzaman/dashboard-changes

Conversation

@azreenz
Copy link
Copy Markdown
Collaborator

@azreenz azreenz commented May 8, 2026

Add note under certain panels that require accounting to be enabled
Screenshot 2026-05-08 153504
Screenshot 2026-05-08 153703

Copilot AI review requested due to automatic review settings May 8, 2026 19:34
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the Grafana dashboards shipped with azure-slurm-exporter to clarify that certain panels will not populate unless Slurm accounting is enabled, helping users quickly diagnose “empty dashboard” scenarios.

Changes:

  • Added a markdown “accounting required” note panel to the Failed Jobs dashboard.
  • Added a markdown “accounting required” note panel beneath the Finished Jobs panel in the main azslurm dashboard.

Scorecard

Criterion Max Points Points Awarded Notes
PR Description Accuracy 20 20 Matches the dashboard note additions.
PR Atomicity 20 20 Single-purpose change (dashboard messaging).
Logical Implementation 10 10 Straightforward dashboard JSON additions.
Regression Risk 10 10 Low risk; informational panels only.
Exception Handling 10 10 N/A for static dashboard JSON.
Code Comments 10 10 N/A for static dashboard JSON.
Repetitive Code 10 10 No meaningful duplication introduced.
Spelling 5 0 Minor grammar/capitalization in new note text.
Logging Quality 5 5 N/A for static dashboard JSON.

FINAL SCORE: 95/100

RECOMMENDATION: MERGE
RATIONALE: Informational-only dashboard changes with low operational risk; minor wording tweaks are optional follow-up items.
BLOCKERS: None

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
azure-slurm-exporter/dashboards/failed-jobs.json Adds a text panel note indicating Slurm accounting is required for the dashboard to populate.
azure-slurm-exporter/dashboards/azslurm.json Adds a text panel note under the Finished Jobs panel indicating Slurm accounting is required.

Comment thread azure-slurm-exporter/dashboards/failed-jobs.json Outdated
Comment thread azure-slurm-exporter/dashboards/azslurm.json Outdated
azreenz and others added 2 commits May 8, 2026 15:39
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
@azreenz azreenz merged commit 64cfca5 into master May 11, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants