add support for aarch64 architecture#546
Merged
davidgamero merged 14 commits intoJun 10, 2025
Merged
Conversation
UdeshyaDhungana
changed the title
Tatsinnit
approved these changes
May 6, 2025
Tatsinnit
requested review from
ReinierCC,
bosesuneha,
davidgamero,
qpetraroia and
tejhan
Collaborator
|
lgtm i see the same in goreleaser https://github.com/goreleaser/goreleaser/blob/d7193e3289f8e913313b3d7fbf48a8e295f78ea7/internal/builders/zig/targets.go#L61 |
davidgamero
approved these changes
May 7, 2025
Collaborator
davidgamero
left a comment
davidgamero
left a comment
There was a problem hiding this comment.
lgtm thank you for the contribution!
Contributor
Author
You're welcome :) |
Collaborator
|
@UdeshyaDhungana your first commit 75ebab3 is unsigned, if you can sign it we can merge this |
Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Tatsinnit <tatsatmishra@gmail.com>
Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Tatsinnit <tatsatmishra@gmail.com> Co-authored-by: Suneha Bose <123775811+bosesuneha@users.noreply.github.com>
Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
auto-merge was automatically disabled
May 26, 2025 14:35
Head branch was pushed to by a user without write access
UdeshyaDhungana
force-pushed
the
udeshyadhungana/aarch64-install-support
branch
from
2e9ab1c to
7415926
Compare
Contributor
Author
|
@microsoft-github-policy-service agree |
Contributor
Author
|
Hi @davidgamero , I have signed the commit. Please note that the hash was changed since I had to re-base and amend the commit. Please let me know if there are any additional steps I need to take. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I have added support for aarch64 architecture in the installation script.
Fixes #515 (issue)
Type of change
How Has This Been Tested?
Checklist: